Fix potential recursion/duplicate object detection #54018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
twangboy
approved these changes
Jul 25, 2019
It's unlikely, but possible, that we could get a problem with over-eager detection of recursion. Especially in the cases of short interned strings or small numbers on CPython, since those are cached. Instead we'll just check of it's a type that we're going to recurse on.
waynew
force-pushed
the
more-recursive-msgpack-fix
branch
from
ea812c2 to
a715b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's unlikely, but possible, that we could get a problem with over-eager
detection of recursion. Especially in the cases of short interned
strings or small numbers on CPython, since those are cached. Instead
we'll just check of it's a type that we're going to recurse on.
What issues does this PR fix or reference?
previous PR #51322
#37646
Previous Behavior
In the extremely unlikely event that we were setting the same object multiple places, or the incredibly unlikely event that we were returning a short string, or the potential case where we were returning two of the same number, it's possible that we could be overeager in our recursion detection.
This stops that.
New Behavior
Only detect recursion on objects that we're going to recurse on.
Tests written?
Yes
Commits signed with GPG?
Yes