Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win runas plus #54277

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Win runas plus #54277

merged 3 commits into from
Aug 21, 2019

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Aug 21, 2019

  • Use super instead of __new__ in MultiprocessingProcess
  • Don't delete attributes from MultiprocessingProcess
  • Don't try to close handles unless they exist

Tests written?

No - Covered by existing tests

Commits signed with GPG?

Yes

@dwoz dwoz added the ZZZWarRoom retired label War Room Issues label Aug 21, 2019
@dwoz dwoz merged commit de77762 into saltstack:2019.2.1 Aug 21, 2019
@s0undt3ch s0undt3ch mentioned this pull request Oct 20, 2019
Merged
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request Oct 29, 2019
@s0undt3ch
Fix multiprocessing process after fork and finalize regression
3f43ab8 
PR saltstack#54277 introduced a regression where `salt.utils.process.Process`
subclasses which override their `run()` method would not have the
`_after_fork_methods` and `_finalize_methods` executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Akm0d Akm0d Akm0d approved these changes

Assignees
No one assigned
Labels
ZZZWarRoom retired label War Room Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwoz @waynew @s0undt3ch @Akm0d