Fix multiprocessing process after fork and finalize regression #55065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
commented
Oct 20, 2019
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
from
2140e98 to
f230cac
Compare
|
Not Ready. |
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
from
f230cac to
4046e54
Compare
|
PR is now ready. |
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
7 times, most recently
from
37c6f35 to
3992d79
Compare
dwoz
approved these changes
Oct 24, 2019
waynew
approved these changes
Oct 24, 2019
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
2 times, most recently
from
247c9da to
bf8b8c5
Compare
Akm0d
approved these changes
Oct 29, 2019
PR saltstack#54277 introduced a regression where `salt.utils.process.Process` subclasses which override their `run()` method would not have the `_after_fork_methods` and `_finalize_methods` executed.
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
from
bf8b8c5 to
b41259c
Compare
s0undt3ch
force-pushed
the
hotfix/process-after-fork-regression
branch
from
b41259c to
d60060c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix multiprocessing process after fork and finalize regression
PR #54277 introduced a regression where
salt.utils.process.Processsubclasses which override their
run()method would not have the_after_fork_methodsand_finalize_methodsexecuted.What issues does this PR fix or reference?
This PR must be merged after #55043 since it relies on the new class names.
Previous Behavior
Classes which sub-classed
salt.utils.process.Processorsalt.utils.process.SignalHandlingProcesswhich also defined arun()method would not run through the_after_fork_methodsand_finalize_methods.New Behavior
Classes which subclass
salt.utils.process.Processorsalt.utils.process.SignalHandlingProcesswhich also defines arun()will run through the_after_fork_methodsand_finalize_methods.Tests written?
Yes
Commits signed with GPG?
Yes