Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lo.WaitFor #269

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Adding lo.WaitFor #269

merged 4 commits into from
Jun 28, 2024

Conversation

samber
Copy link
Owner

@samber samber commented Nov 15, 2022

ok := WaitFor(func(i int) bool {
	return i % 3 == 2
}, 10*time.Millisecond, time.Millisecond)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (c23c040) to head (173088f).
Report is 15 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   94.00%   94.64%   +0.64%     
==========================================
  Files          16       17       +1     
  Lines        2500     2892     +392     
==========================================
+ Hits         2350     2737     +387     
- Misses        148      154       +6     
+ Partials        2        1       -1     
Flag Coverage Δ
unittests 94.64% <100.00%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samber samber merged commit 263c266 into master Jun 28, 2024
14 checks passed
@@ -93,3 +96,35 @@ func Async6[A, B, C, D, E, F any](f func() (A, B, C, D, E, F)) <-chan Tuple6[A,
}()
return ch
}

// WaitFor runs periodically until a condition is validated.
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this

Suggested change
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
return WaitForWithCtx(context.Background(), condition, maxDuration, tick)
}
// WaitForWithCtx runs periodically until a condition is validated or context is cancelled
func WaitForWithCtx(ctx context.Context, condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) {
if condition(0) {
return 1, 0, true
}
start := time.Now()
timer := time.NewTimer(maxDuration)
ticker := time.NewTicker(tick)
defer func() {
timer.Stop()
ticker.Stop()
}()
i := 1
for {
select {
case <-ctx.Done():
return i, time.Since(start), false
case <-timer.C:
return i, time.Since(start), false
case <-ticker.C:
if condition(i) {
return i + 1, time.Since(start), true
}
i++
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a new PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-actions bot pushed a commit to kairos-io/provider-kairos that referenced this pull request Jun 28, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://github.com/samber/lo) | `v1.42.0` ->
`v1.43.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.42.0/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.42.0/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>samber/lo (github.com/samber/lo)</summary>

### [`v1.43.0`](https://github.com/samber/lo/releases/tag/v1.43.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.42.0...v1.43.0)

#### What's Changed

- feat: adding HasKey by [@&#8203;samber](https://github.com/samber)
in
[samber/lo#477
- feat: adding lo.WaitFor by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#269
- improvement: Optimize the performance of union method, avoid repeated
expansion by [@&#8203;cwb2819259](https://github.com/cwb2819259) in
[samber/lo#397

#### New Contributors

- [@&#8203;cwb2819259](https://github.com/cwb2819259) made their first
contribution in
[samber/lo#397

**Full Changelog**:
samber/lo@v1.42.0...v1.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@samber samber deleted the feat-concurrency-waitFor branch June 29, 2024 17:31
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jul 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://github.com/samber/lo) | `v1.39.0` ->
`v1.44.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>samber/lo (github.com/samber/lo)</summary>

### [`v1.44.0`](https://github.com/samber/lo/releases/tag/v1.44.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.43.0...v1.44.0)

#### What's Changed

- feat: Add slice Splice an element or multiple elements at index i. by
[@&#8203;wenlingang](https://github.com/wenlingang) in
[samber/lo#371
- feat: Make Filter() preserve type. by
[@&#8203;FGasper](https://github.com/FGasper) in
[samber/lo#365
- feat: Added DropByIndex helper for slice by
[@&#8203;phith0n](https://github.com/phith0n) in
[samber/lo#398
- feat: upgrade to math/rand/v2 by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#483
- chore: remove `golang.org/x/exp` since it doesn't follow go 1
compatibility promise by [@&#8203;trim21](https://github.com/trim21)
in
[samber/lo#478

#### New Contributors

- [@&#8203;wenlingang](https://github.com/wenlingang) made their first
contribution in
[samber/lo#371
- [@&#8203;jason-zhj](https://github.com/jason-zhj) made their first
contribution in
[samber/lo#376
- [@&#8203;FGasper](https://github.com/FGasper) made their first
contribution in
[samber/lo#365
- [@&#8203;phith0n](https://github.com/phith0n) made their first
contribution in
[samber/lo#398

**Full Changelog**:
samber/lo@v1.43.0...v1.44.0

### [`v1.43.0`](https://github.com/samber/lo/releases/tag/v1.43.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.42.0...v1.43.0)

#### What's Changed

- feat: adding HasKey by [@&#8203;samber](https://github.com/samber)
in
[samber/lo#477
- feat: adding lo.WaitFor by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#269
- improvement: Optimize the performance of union method, avoid repeated
expansion by [@&#8203;cwb2819259](https://github.com/cwb2819259) in
[samber/lo#397

#### New Contributors

- [@&#8203;cwb2819259](https://github.com/cwb2819259) made their first
contribution in
[samber/lo#397

**Full Changelog**:
samber/lo@v1.42.0...v1.43.0

### [`v1.42.0`](https://github.com/samber/lo/releases/tag/v1.42.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.41.0...v1.42.0)

#### What's Changed

- feat: add Nil by [@&#8203;gubtos](https://github.com/gubtos) in
[samber/lo#383
- feat: Add First and FirstOrZeroValue functions by
[@&#8203;Alireza-Kiani](https://github.com/Alireza-Kiani) in
[samber/lo#451
- feat: adding LastOrEmpty and LastOr by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#474
- feat: Feature/contains iterate by index by
[@&#8203;lennon-guan](https://github.com/lennon-guan) in
[samber/lo#428
- feat: speed up loops by reducing allocations by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#475
- doc: inconsistent expression in README.md by
[@&#8203;rolancia](https://github.com/rolancia) in
[samber/lo#406

#### New Contributors

- [@&#8203;gubtos](https://github.com/gubtos) made their first
contribution in
[samber/lo#383
- [@&#8203;Alireza-Kiani](https://github.com/Alireza-Kiani) made their
first contribution in
[samber/lo#451
- [@&#8203;rolancia](https://github.com/rolancia) made their first
contribution in
[samber/lo#406
- [@&#8203;lennon-guan](https://github.com/lennon-guan) made their
first contribution in
[samber/lo#428

**Full Changelog**:
samber/lo@v1.41.0...v1.42.0

### [`v1.41.0`](https://github.com/samber/lo/releases/tag/v1.41.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.40.0...v1.41.0)

#### What's Changed

- feat: adding Elipse by [@&#8203;samber](https://github.com/samber)
in
[samber/lo#470
- feat: adding CoalesceOrEmpty by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#469
- feat: adding Earliest and Latest by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#468
- feat: adding duration by [@&#8203;samber](https://github.com/samber)
in
[samber/lo#471
- feat: adding FilterReject by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#472
- feat: adding RejectMap by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#473

**Full Changelog**:
samber/lo@v1.34.0...v1.41.0

### [`v1.40.0`](https://github.com/samber/lo/releases/tag/v1.40.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.39.0...v1.40.0)

#### What's Changed

##### Improvements

- Use map indexing to speed up PickByKeys and OmitByKeys by
[@&#8203;ericleb010](https://github.com/ericleb010) in
[samber/lo#447
- ToSlicePtr: reduce allocations and improving speed by
[@&#8203;yanmhlv](https://github.com/yanmhlv) in
[samber/lo#465
- Feat: Adding zipby + unzipby by
[@&#8203;samber](https://github.com/samber) in
[samber/lo#449
- feat: add string conversion functions by
[@&#8203;eiixy](https://github.com/eiixy) in
[samber/lo#466
- Adding Mean and MeanBy by
[@&#8203;usman1100](https://github.com/usman1100) in
[samber/lo#414

##### Doc & style

- Fix typos by [@&#8203;szepeviktor](https://github.com/szepeviktor)
in
[samber/lo#384
- fix: instantiate typo by
[@&#8203;testwill](https://github.com/testwill) in
[samber/lo#374
- Fix typo in README.md by
[@&#8203;eltociear](https://github.com/eltociear) in
[samber/lo#369
- docs: update description for FindOrElse by
[@&#8203;slomek](https://github.com/slomek) in
[samber/lo#370
- style: no extra any type parameter by
[@&#8203;d-enk](https://github.com/d-enk) in
[samber/lo#429
- Fix IsNil link for pkg.go.dev by
[@&#8203;invzhi](https://github.com/invzhi) in
[samber/lo#418
- Docs: should use type int64 for lo.FlatMap in example by
[@&#8203;apriil15](https://github.com/apriil15) in
[samber/lo#435

##### CI

- CI: tests on multi go versions by
[@&#8203;jiro4989](https://github.com/jiro4989) in
[samber/lo#445

#### New Contributors

- [@&#8203;szepeviktor](https://github.com/szepeviktor) made their
first contribution in
[samber/lo#384
- [@&#8203;testwill](https://github.com/testwill) made their first
contribution in
[samber/lo#374
- [@&#8203;eltociear](https://github.com/eltociear) made their first
contribution in
[samber/lo#369
- [@&#8203;slomek](https://github.com/slomek) made their first
contribution in
[samber/lo#370
- [@&#8203;ericleb010](https://github.com/ericleb010) made their first
contribution in
[samber/lo#447
- [@&#8203;yanmhlv](https://github.com/yanmhlv) made their first
contribution in
[samber/lo#465
- [@&#8203;eiixy](https://github.com/eiixy) made their first
contribution in
[samber/lo#466
- [@&#8203;jiro4989](https://github.com/jiro4989) made their first
contribution in
[samber/lo#445
- [@&#8203;d-enk](https://github.com/d-enk) made their first
contribution in
[samber/lo#429
- [@&#8203;usman1100](https://github.com/usman1100) made their first
contribution in
[samber/lo#414
- [@&#8203;invzhi](https://github.com/invzhi) made their first
contribution in
[samber/lo#418
- [@&#8203;apriil15](https://github.com/apriil15) made their first
contribution in
[samber/lo#435

**Full Changelog**:
samber/lo@v1.39.0...v1.40.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants