-
-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lo.WaitFor #269
Adding lo.WaitFor #269
Conversation
samber
commented
Nov 15, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 94.00% 94.64% +0.64%
==========================================
Files 16 17 +1
Lines 2500 2892 +392
==========================================
+ Hits 2350 2737 +387
- Misses 148 154 +6
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d91b023
to
0be7871
Compare
0be7871
to
aaebc3f
Compare
@@ -93,3 +96,35 @@ func Async6[A, B, C, D, E, F any](f func() (A, B, C, D, E, F)) <-chan Tuple6[A, | |||
}() | |||
return ch | |||
} | |||
|
|||
// WaitFor runs periodically until a condition is validated. | |||
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) { | |
func WaitFor(condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) { | |
return WaitForWithCtx(context.Background(), condition, maxDuration, tick) | |
} | |
// WaitForWithCtx runs periodically until a condition is validated or context is cancelled | |
func WaitForWithCtx(ctx context.Context, condition func(i int) bool, maxDuration time.Duration, tick time.Duration) (int, time.Duration, bool) { | |
if condition(0) { | |
return 1, 0, true | |
} | |
start := time.Now() | |
timer := time.NewTimer(maxDuration) | |
ticker := time.NewTicker(tick) | |
defer func() { | |
timer.Stop() | |
ticker.Stop() | |
}() | |
i := 1 | |
for { | |
select { | |
case <-ctx.Done(): | |
return i, time.Since(start), false | |
case <-timer.C: | |
return i, time.Since(start), false | |
case <-ticker.C: | |
if condition(i) { | |
return i + 1, time.Since(start), true | |
} | |
i++ | |
} | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://github.com/samber/lo) | `v1.42.0` -> `v1.43.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.42.0/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.42.0/v1.43.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.43.0`](https://github.com/samber/lo/releases/tag/v1.43.0) [Compare Source](https://github.com/samber/lo/compare/v1.42.0...v1.43.0) #### What's Changed - feat: adding HasKey by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/477](https://github.com/samber/lo/pull/477) - feat: adding lo.WaitFor by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/269](https://github.com/samber/lo/pull/269) - improvement: Optimize the performance of union method, avoid repeated expansion by [@​cwb2819259](https://github.com/cwb2819259) in [https://github.com/samber/lo/pull/397](https://github.com/samber/lo/pull/397) #### New Contributors - [@​cwb2819259](https://github.com/cwb2819259) made their first contribution in [https://github.com/samber/lo/pull/397](https://github.com/samber/lo/pull/397) **Full Changelog**: samber/lo@v1.42.0...v1.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://github.com/samber/lo) | `v1.39.0` -> `v1.44.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.39.0/v1.44.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.44.0`](https://github.com/samber/lo/releases/tag/v1.44.0) [Compare Source](https://github.com/samber/lo/compare/v1.43.0...v1.44.0) #### What's Changed - feat: Add slice Splice an element or multiple elements at index i. by [@​wenlingang](https://github.com/wenlingang) in [https://github.com/samber/lo/pull/371](https://github.com/samber/lo/pull/371) - feat: Make Filter() preserve type. by [@​FGasper](https://github.com/FGasper) in [https://github.com/samber/lo/pull/365](https://github.com/samber/lo/pull/365) - feat: Added DropByIndex helper for slice by [@​phith0n](https://github.com/phith0n) in [https://github.com/samber/lo/pull/398](https://github.com/samber/lo/pull/398) - feat: upgrade to math/rand/v2 by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/483](https://github.com/samber/lo/pull/483) - chore: remove `golang.org/x/exp` since it doesn't follow go 1 compatibility promise by [@​trim21](https://github.com/trim21) in [https://github.com/samber/lo/pull/478](https://github.com/samber/lo/pull/478) #### New Contributors - [@​wenlingang](https://github.com/wenlingang) made their first contribution in [https://github.com/samber/lo/pull/371](https://github.com/samber/lo/pull/371) - [@​jason-zhj](https://github.com/jason-zhj) made their first contribution in [https://github.com/samber/lo/pull/376](https://github.com/samber/lo/pull/376) - [@​FGasper](https://github.com/FGasper) made their first contribution in [https://github.com/samber/lo/pull/365](https://github.com/samber/lo/pull/365) - [@​phith0n](https://github.com/phith0n) made their first contribution in [https://github.com/samber/lo/pull/398](https://github.com/samber/lo/pull/398) **Full Changelog**: samber/lo@v1.43.0...v1.44.0 ### [`v1.43.0`](https://github.com/samber/lo/releases/tag/v1.43.0) [Compare Source](https://github.com/samber/lo/compare/v1.42.0...v1.43.0) #### What's Changed - feat: adding HasKey by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/477](https://github.com/samber/lo/pull/477) - feat: adding lo.WaitFor by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/269](https://github.com/samber/lo/pull/269) - improvement: Optimize the performance of union method, avoid repeated expansion by [@​cwb2819259](https://github.com/cwb2819259) in [https://github.com/samber/lo/pull/397](https://github.com/samber/lo/pull/397) #### New Contributors - [@​cwb2819259](https://github.com/cwb2819259) made their first contribution in [https://github.com/samber/lo/pull/397](https://github.com/samber/lo/pull/397) **Full Changelog**: samber/lo@v1.42.0...v1.43.0 ### [`v1.42.0`](https://github.com/samber/lo/releases/tag/v1.42.0) [Compare Source](https://github.com/samber/lo/compare/v1.41.0...v1.42.0) #### What's Changed - feat: add Nil by [@​gubtos](https://github.com/gubtos) in [https://github.com/samber/lo/pull/383](https://github.com/samber/lo/pull/383) - feat: Add First and FirstOrZeroValue functions by [@​Alireza-Kiani](https://github.com/Alireza-Kiani) in [https://github.com/samber/lo/pull/451](https://github.com/samber/lo/pull/451) - feat: adding LastOrEmpty and LastOr by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/474](https://github.com/samber/lo/pull/474) - feat: Feature/contains iterate by index by [@​lennon-guan](https://github.com/lennon-guan) in [https://github.com/samber/lo/pull/428](https://github.com/samber/lo/pull/428) - feat: speed up loops by reducing allocations by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/475](https://github.com/samber/lo/pull/475) - doc: inconsistent expression in README.md by [@​rolancia](https://github.com/rolancia) in [https://github.com/samber/lo/pull/406](https://github.com/samber/lo/pull/406) #### New Contributors - [@​gubtos](https://github.com/gubtos) made their first contribution in [https://github.com/samber/lo/pull/383](https://github.com/samber/lo/pull/383) - [@​Alireza-Kiani](https://github.com/Alireza-Kiani) made their first contribution in [https://github.com/samber/lo/pull/451](https://github.com/samber/lo/pull/451) - [@​rolancia](https://github.com/rolancia) made their first contribution in [https://github.com/samber/lo/pull/406](https://github.com/samber/lo/pull/406) - [@​lennon-guan](https://github.com/lennon-guan) made their first contribution in [https://github.com/samber/lo/pull/428](https://github.com/samber/lo/pull/428) **Full Changelog**: samber/lo@v1.41.0...v1.42.0 ### [`v1.41.0`](https://github.com/samber/lo/releases/tag/v1.41.0) [Compare Source](https://github.com/samber/lo/compare/v1.40.0...v1.41.0) #### What's Changed - feat: adding Elipse by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/470](https://github.com/samber/lo/pull/470) - feat: adding CoalesceOrEmpty by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/469](https://github.com/samber/lo/pull/469) - feat: adding Earliest and Latest by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/468](https://github.com/samber/lo/pull/468) - feat: adding duration by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/471](https://github.com/samber/lo/pull/471) - feat: adding FilterReject by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/472](https://github.com/samber/lo/pull/472) - feat: adding RejectMap by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/473](https://github.com/samber/lo/pull/473) **Full Changelog**: samber/lo@v1.34.0...v1.41.0 ### [`v1.40.0`](https://github.com/samber/lo/releases/tag/v1.40.0) [Compare Source](https://github.com/samber/lo/compare/v1.39.0...v1.40.0) #### What's Changed ##### Improvements - Use map indexing to speed up PickByKeys and OmitByKeys by [@​ericleb010](https://github.com/ericleb010) in [https://github.com/samber/lo/pull/447](https://github.com/samber/lo/pull/447) - ToSlicePtr: reduce allocations and improving speed by [@​yanmhlv](https://github.com/yanmhlv) in [https://github.com/samber/lo/pull/465](https://github.com/samber/lo/pull/465) - Feat: Adding zipby + unzipby by [@​samber](https://github.com/samber) in [https://github.com/samber/lo/pull/449](https://github.com/samber/lo/pull/449) - feat: add string conversion functions by [@​eiixy](https://github.com/eiixy) in [https://github.com/samber/lo/pull/466](https://github.com/samber/lo/pull/466) - Adding Mean and MeanBy by [@​usman1100](https://github.com/usman1100) in [https://github.com/samber/lo/pull/414](https://github.com/samber/lo/pull/414) ##### Doc & style - Fix typos by [@​szepeviktor](https://github.com/szepeviktor) in [https://github.com/samber/lo/pull/384](https://github.com/samber/lo/pull/384) - fix: instantiate typo by [@​testwill](https://github.com/testwill) in [https://github.com/samber/lo/pull/374](https://github.com/samber/lo/pull/374) - Fix typo in README.md by [@​eltociear](https://github.com/eltociear) in [https://github.com/samber/lo/pull/369](https://github.com/samber/lo/pull/369) - docs: update description for FindOrElse by [@​slomek](https://github.com/slomek) in [https://github.com/samber/lo/pull/370](https://github.com/samber/lo/pull/370) - style: no extra any type parameter by [@​d-enk](https://github.com/d-enk) in [https://github.com/samber/lo/pull/429](https://github.com/samber/lo/pull/429) - Fix IsNil link for pkg.go.dev by [@​invzhi](https://github.com/invzhi) in [https://github.com/samber/lo/pull/418](https://github.com/samber/lo/pull/418) - Docs: should use type int64 for lo.FlatMap in example by [@​apriil15](https://github.com/apriil15) in [https://github.com/samber/lo/pull/435](https://github.com/samber/lo/pull/435) ##### CI - CI: tests on multi go versions by [@​jiro4989](https://github.com/jiro4989) in [https://github.com/samber/lo/pull/445](https://github.com/samber/lo/pull/445) #### New Contributors - [@​szepeviktor](https://github.com/szepeviktor) made their first contribution in [https://github.com/samber/lo/pull/384](https://github.com/samber/lo/pull/384) - [@​testwill](https://github.com/testwill) made their first contribution in [https://github.com/samber/lo/pull/374](https://github.com/samber/lo/pull/374) - [@​eltociear](https://github.com/eltociear) made their first contribution in [https://github.com/samber/lo/pull/369](https://github.com/samber/lo/pull/369) - [@​slomek](https://github.com/slomek) made their first contribution in [https://github.com/samber/lo/pull/370](https://github.com/samber/lo/pull/370) - [@​ericleb010](https://github.com/ericleb010) made their first contribution in [https://github.com/samber/lo/pull/447](https://github.com/samber/lo/pull/447) - [@​yanmhlv](https://github.com/yanmhlv) made their first contribution in [https://github.com/samber/lo/pull/465](https://github.com/samber/lo/pull/465) - [@​eiixy](https://github.com/eiixy) made their first contribution in [https://github.com/samber/lo/pull/466](https://github.com/samber/lo/pull/466) - [@​jiro4989](https://github.com/jiro4989) made their first contribution in [https://github.com/samber/lo/pull/445](https://github.com/samber/lo/pull/445) - [@​d-enk](https://github.com/d-enk) made their first contribution in [https://github.com/samber/lo/pull/429](https://github.com/samber/lo/pull/429) - [@​usman1100](https://github.com/usman1100) made their first contribution in [https://github.com/samber/lo/pull/414](https://github.com/samber/lo/pull/414) - [@​invzhi](https://github.com/invzhi) made their first contribution in [https://github.com/samber/lo/pull/418](https://github.com/samber/lo/pull/418) - [@​apriil15](https://github.com/apriil15) made their first contribution in [https://github.com/samber/lo/pull/435](https://github.com/samber/lo/pull/435) **Full Changelog**: samber/lo@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>