Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WaitForWithContext #480

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat: add WaitForWithContext #480

merged 5 commits into from
Jul 15, 2024

Conversation

ccoVeille
Copy link
Contributor

@ccoVeille ccoVeille commented Jun 29, 2024 •
edited
Loading

@ccoVeille ccoVeille mentioned this pull request Jun 29, 2024
Merged
@ccoVeille
Copy link
Contributor Author

Please review, you will tell me if it's OK for you

I didn't check if you had other method that could be improved by having a context. Let me know, and I can add method if you want

samber
samber reviewed Jun 30, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
samber
samber reviewed Jun 30, 2024
View reviewed changes
concurrency.go Outdated Show resolved Hide resolved
@ccoVeille
Copy link
Contributor Author

ccoVeille commented Jun 30, 2024 •
edited
Loading

I neex to add test to validate the context passed to condition is canceled

@ccoVeille ccoVeille marked this pull request as draft June 30, 2024 09:50
ccoVeille
ccoVeille commented Jun 30, 2024
View reviewed changes
concurrency.go Outdated Show resolved Hide resolved
concurrency.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille commented Jun 30, 2024
View reviewed changes
concurrency.go Outdated Show resolved Hide resolved
@ccoVeille
chore: fix test timeout helper
2cce8d8 
using os.Exit(1) kills everything, tests statuses are not always displayed
@ccoVeille
chore: refactor WaitFor unit tests
e26f1b4 
zero-code changes
@ccoVeille
fix: WaitFor on first condition
071a746 
duration must be non-zero if first conditions is true
@ccoVeille ccoVeille marked this pull request as ready for review July 2, 2024 22:44
@ccoVeille ccoVeille requested a review from samber July 2, 2024 22:45
@ccoVeille
Copy link
Contributor Author

@samber ?

@samber
Copy link
Owner

samber commented Jul 15, 2024

Sorry for the delay. Let's merge ;)

@samber samber merged commit 0f4679b into samber:master Jul 15, 2024
6 of 7 checks passed
@ccoVeille ccoVeille deleted the waitfor branch July 15, 2024 17:34
@ccoVeille
Copy link
Contributor Author

Thanks

github-actions bot pushed a commit to kairos-io/provider-kairos that referenced this pull request Jul 15, 2024
@renovate
fix(deps): update module github.com/samber/lo to v1.46.0 (#604)
8bdabec 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/lo](https://github.com/samber/lo) | `v1.45.0` ->
`v1.46.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.45.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.45.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>samber/lo (github.com/samber/lo)</summary>

### [`v1.46.0`](https://github.com/samber/lo/releases/tag/v1.46.0)

[Compare
Source](https://github.com/samber/lo/compare/v1.45.0...v1.46.0)

#### What's Changed

- fix: chunk memory leak, bug fix by
[@&#8203;mihir20](https://github.com/mihir20) in
[samber/lo#491
- feat: add WaitForWithContext by
[@&#8203;ccoVeille](https://github.com/ccoVeille) in
[samber/lo#480
- add ForEachCondition implement by
[@&#8203;Sianao](https://github.com/Sianao) in
[samber/lo#485

#### New Contributors

- [@&#8203;mihir20](https://github.com/mihir20) made their first
contribution in
[samber/lo#491
- [@&#8203;ccoVeille](https://github.com/ccoVeille) made their first
contribution in
[samber/lo#480
- [@&#8203;Sianao](https://github.com/Sianao) made their first
contribution in
[samber/lo#485

**Full Changelog**:
samber/lo@v1.45.0...v1.46.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samber samber samber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccoVeille @samber