Expose the ability to encode a Genotoype into a GT field #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
approved these changes
Jan 30, 2023
|
|
||
| Assert.assertEquals(VCFEncoder.encodeGtField(vc, g1), "0/0"); | ||
| Assert.assertEquals(VCFEncoder.encodeGtField(vc, g2), "1/2"); | ||
| } |
There was a problem hiding this comment.
Can you add a unit test for writeGtField() as well?
* Expose two public methods in VCFEncoder writeGtField and encodeGtField * Supports broadinstitute/gatk#8160 but seems like a useful thing to be able to do in general * minor breaking change in VCFEncoder, made methods formatVCFField and buildAlleleStrings static It is unlikely anyone overrides either of these methods so it should not be a problem.
lbergelson
force-pushed
the
lb_expose_gt_encoding
branch
from
6f5230f to
0e6e942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unlikely anyone overrides either of these methods so it should not be a problem.