copy + get_resources + invertible swap gate fix #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesB-1qbit
requested review from
ValentinS4t1qbit and
alexfleury-sb
as code owners
ValentinS4t1qbit
requested changes
Aug 15, 2022
It makes sense to guarantee that `(c == c.copy())` always returns `True`. The `==` operator between two circuits looks for width and gate list, therefore we should use width in the copy function.
ValentinS4t1qbit
approved these changes
Aug 15, 2022
ValentinS4t1qbit
approved these changes
Aug 16, 2022
ValentinS4t1qbit
added a commit
that referenced
this pull request
Aug 25, 2022
* Formula for estimating n_measurements for exp value to given accuracy updated with simpler form. (#192) * Fix operator_expectation bug qith qubit operator / hamiltonian. (#191) * iqcc ilc solver fork (#179) * Make circuit iterable (#194) * copy method for circuits + get_resources adjusted for some variations of VQE + invertible swap gate fix (#193) * get_resources methods adjusted (VQE, SA-VQE) * Release guide for project maintainers + version string (#195) * Notebook: Important aspects of QChem modelling for QComputing (#199) * Notebooks enabled for Google colab ("No local install") (#198) * Docker fix (#200) * Excited states notebook (#197) * Translation function for qiskit qubit operators (paulisumop) (#196) Co-authored-by: Valentin Senicourt <valentin.senicourt@1qbit.com> Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com> Co-authored-by: JamesB-1qbit <84878946+JamesB-1qbit@users.noreply.github.com> Co-authored-by: MPCoons <84400409+MPCoons@users.noreply.github.com>
ValentinS4t1qbit
added a commit
that referenced
this pull request
Nov 9, 2022
* Formula for estimating n_measurements for exp value to given accuracy updated with simpler form. (#192) * Fix operator_expectation bug qith qubit operator / hamiltonian. (#191) * iqcc ilc solver fork (#179) * Make circuit iterable (#194) * copy method for circuits + get_resources adjusted for some variations of VQE + invertible swap gate fix (#193) * Release guide for project maintainers + version string (#195) * Notebook: Important aspects of QChem modelling for QComputing (#199) * Notebooks enabled for Google colab ("No local install" needed) (#198) * Docker fix (#200) * Excited states (#197) * Translation function for qubit operators (#196) * c2v axis definition changed (#205) * Bidirectional conversion for Qiskit quantum circuits (#203) * QEMISTClientConnection class (#207) * Add n_qubits option to MultiformOperator compress function (#209) * Quantum Signal Processing time-evolution (#204) * added even trotter order > 2 (#210) * Fixed number of qubits with scBK in ADAPT. (#214) * Export coverage output file in github actions (#158) * JKMN vector prep should return np array of int. (#215) * Support for additional IonQ gates (#212) * Remove unused n_min_orbitals attribute. (#218) * Change JKMN Majorana definition so mapped Hamiltonian is real (#219) * Relaxing condition fot iQCC-ILC test. (#221) * Histogram class (#217) * Compute energy from RDMs with FermionOperator (#220) * IonQConnection: control update prints / verbosity. (#225) * Refactor simulator (#213) * added __repr__ method to Gate (#229) * New bidirectional circuit translation functions and interface (#223) * Add circuit.depth() in get_resources methods (#235) * Variance and standard error of an expectation value (#238) * VQESolver cleanup (#230) * TETRIS-ADAPT-VQE (#241) * TETRISADAPTSolver implementation + #224 fix * Trotter order and active electrons for (i)QCC (#234) * Symmetry post-selection (#232) * Qiskit runtime integration (IBM quantum only) (#222) * Add multi-control support for trotterization (#244) * Compatibility with new QCloud outputs. (#246) * Deprecate Simulator, introduce get_backend as replacement (#245) * compute_rdms function (#228) * Expanded FermionOperator attributes, defined logical and mathematical operations on it (add, mul, eq, etc) * Bumping Tangelo version number in _version.py * Update CHANGELOG.md Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com> Co-authored-by: James Brown <james.brown@1qbit.com> Co-authored-by: JamesB-1qbit <84878946+JamesB-1qbit@users.noreply.github.com> Co-authored-by: MPCoons <84400409+MPCoons@users.noreply.github.com> Co-authored-by: elloyd-1qbit <58313607+elloyd-1qbit@users.noreply.github.com> Co-authored-by: KrzysztofB-1qbit <86750444+KrzysztofB-1qbit@users.noreply.github.com> Co-authored-by: Rudi Plesch <rudi.plesch@1qbit.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Valentin Senicourt <valentin.senicourt@1qbit.com> Co-authored-by: Joshua Goings <3915169+jjgoings@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small fixes.