Refactor simulator #213

JamesB-1qbit · 2022-09-15T13:30:13Z

Makes each target it's own class with SimulatorBase as a parent class. The majority of the code is copied/pasted.

…ctions

ValentinS4t1qbit

I think we can improve a few things, overall I think this redesign is great and what we needed. Thank you for pushing this forward.

You probably have done it already, but think about how your design will be able to handle the multiplication of simulators / backends coming from Cirq, Qiskit, Qualms etc that we may want to support, as well as new simulator frameworks that simply have not been integrated to Tangelo at all.

tangelo/linq/target/target_cirq.py

tangelo/linq/simulator.py

tangelo/linq/target/__init__.py

tangelo/linq/target/target_cirq.py

tangelo/linq/simulator.py

examples/linq/1.the_basics.ipynb

tangelo/linq/target/target_cirq.py

tangelo/linq/simulator.py

…y on target call

ValentinS4t1qbit

I apologize, I reviewed a bit too quickly the first time and I think your Simulator wrapper function requires work.

I'm grateful for the opportunity to think about this design change, which brings out some subtleties we hadn't faced before.

tangelo/linq/target/__init__.py

tangelo/linq/target/target_qulacs.py

tangelo/linq/tests/test_simulator.py

tangelo/toolboxes/measurements/qubit_terms_grouping.py

tangelo/helpers/utils.py

tangelo/linq/simulator.py

tangelo/linq/tests/test_simulator_noisy.py

ValentinS4t1qbit

A number of improvements to make. I want to recognize that this PR is getting a lot of comments because:

you are introducing several non-trivial badass features
you are introducing patterns we haven't used before, therefore learning and challenging us and yourself.

As far as I'm concerned, this is an amazing PR. Please keep up the good work and take us to the finish line.

tangelo/linq/tests/test_simulator.py

tangelo/linq/simulator_base.py

tangelo/linq/simulator.py

alexfleury-sb

I reviewed only the big picture, and I like the modularity it will bring. While looking at TrueFalseSimulator, it seems easy to implement another backend rapidly.

ValentinS4t1qbit

I swear we are getting there.

We are currently importing a class (SimulatorBase) but in reality we just need a function that does not care at all about anything class-related. Instead let's define and import a standalone function. The SimulatorBase can then use that function to implement a method with the same name, and that method can then be automatically leveraged by the children classes, as it currently does. Let's make that method available at the right level of the package using the __init__ files.

This way we have no loss of functionality, and the imports are straightforward. This also means we never need to instantiate SimulatorBase, which is intended to just be a base class for target simulators. Everything seems to fit into place with a clear role, which is a sign of a good design.

tangelo/linq/simulator.py

examples/linq/2.qpu_connection.ipynb

tangelo/linq/simulator_base.py

tangelo/toolboxes/post_processing/histogram.py

ValentinS4t1qbit

Great job James, glad to see this now part of our code !

* Formula for estimating n_measurements for exp value to given accuracy updated with simpler form. (#192) * Fix operator_expectation bug qith qubit operator / hamiltonian. (#191) * iqcc ilc solver fork (#179) * Make circuit iterable (#194) * copy method for circuits + get_resources adjusted for some variations of VQE + invertible swap gate fix (#193) * Release guide for project maintainers + version string (#195) * Notebook: Important aspects of QChem modelling for QComputing (#199) * Notebooks enabled for Google colab ("No local install" needed) (#198) * Docker fix (#200) * Excited states (#197) * Translation function for qubit operators (#196) * c2v axis definition changed (#205) * Bidirectional conversion for Qiskit quantum circuits (#203) * QEMISTClientConnection class (#207) * Add n_qubits option to MultiformOperator compress function (#209) * Quantum Signal Processing time-evolution (#204) * added even trotter order > 2 (#210) * Fixed number of qubits with scBK in ADAPT. (#214) * Export coverage output file in github actions (#158) * JKMN vector prep should return np array of int. (#215) * Support for additional IonQ gates (#212) * Remove unused n_min_orbitals attribute. (#218) * Change JKMN Majorana definition so mapped Hamiltonian is real (#219) * Relaxing condition fot iQCC-ILC test. (#221) * Histogram class (#217) * Compute energy from RDMs with FermionOperator (#220) * IonQConnection: control update prints / verbosity. (#225) * Refactor simulator (#213) * added __repr__ method to Gate (#229) * New bidirectional circuit translation functions and interface (#223) * Add circuit.depth() in get_resources methods (#235) * Variance and standard error of an expectation value (#238) * VQESolver cleanup (#230) * TETRIS-ADAPT-VQE (#241) * TETRISADAPTSolver implementation + #224 fix * Trotter order and active electrons for (i)QCC (#234) * Symmetry post-selection (#232) * Qiskit runtime integration (IBM quantum only) (#222) * Add multi-control support for trotterization (#244) * Compatibility with new QCloud outputs. (#246) * Deprecate Simulator, introduce get_backend as replacement (#245) * compute_rdms function (#228) * Expanded FermionOperator attributes, defined logical and mathematical operations on it (add, mul, eq, etc) * Bumping Tangelo version number in _version.py * Update CHANGELOG.md Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com> Co-authored-by: James Brown <james.brown@1qbit.com> Co-authored-by: JamesB-1qbit <84878946+JamesB-1qbit@users.noreply.github.com> Co-authored-by: MPCoons <84400409+MPCoons@users.noreply.github.com> Co-authored-by: elloyd-1qbit <58313607+elloyd-1qbit@users.noreply.github.com> Co-authored-by: KrzysztofB-1qbit <86750444+KrzysztofB-1qbit@users.noreply.github.com> Co-authored-by: Rudi Plesch <rudi.plesch@1qbit.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Valentin Senicourt <valentin.senicourt@1qbit.com> Co-authored-by: Joshua Goings <3915169+jjgoings@users.noreply.github.com>

JamesB-1qbit force-pushed the refactor_simulator branch from 9308681 to a376d2d Compare September 27, 2022 16:32

JamesB-1qbit added 12 commits September 28, 2022 15:19

refactored simulator

8c1293c

removed target argument from simulator base class

798f627

changed Simulator to function

aac6b7e

added target_qiskit_device

d47d907

import fixes

1bce352

added cirq QVM and qsimcirq backends

3a68e94

added test for rainbow

5db101f

moved QiskitDevice to target_qiskit, added docstrings

920d6ff

added docstrings

abf2e38

fixes for failing tests

285a8d3

simulatorbase backend_info as property

1fe9ba5

updated targets qsimcirq and qiskit

42a841b

JamesB-1qbit force-pushed the refactor_simulator branch from a376d2d to 42a841b Compare September 28, 2022 19:19

JamesB-1qbit added 3 commits September 28, 2022 15:44

utilize histogram for qsimcirq

ed64677

add save_measurements to translation functions

e6678a9

removed noisy fake device simulator, removed changes to translate fun…

ca1c6a5

…ctions

JamesB-1qbit changed the title ~~Refactor simulator WIP~~ Refactor simulator Sep 30, 2022

JamesB-1qbit marked this pull request as ready for review September 30, 2022 13:19

JamesB-1qbit requested review from ValentinS4t1qbit and alexfleury-sb as code owners September 30, 2022 13:19

ValentinS4t1qbit requested changes Sep 30, 2022

View reviewed changes

alexfleury-sb reviewed Sep 30, 2022

View reviewed changes

tangelo/linq/target/target_cirq.py Outdated Show resolved Hide resolved

tangelo/linq/simulator.py Outdated Show resolved Hide resolved

JamesB-1qbit added 2 commits October 3, 2022 12:03

first PR review, moved SimulatorBase to own file, backend imports onl…

a98d0de

…y on target call

docstring and fix for test error

cb133f9

ValentinS4t1qbit requested changes Oct 4, 2022

View reviewed changes

JamesB-1qbit added 3 commits October 4, 2022 12:26

switch Simulator to Class

92c0a75

note -> TODO

9177b94

explicit check for target is None

bbd294a

JamesB-1qbit requested a review from ValentinS4t1qbit October 4, 2022 17:28

ValentinS4t1qbit requested changes Oct 5, 2022

View reviewed changes

JamesB-1qbit added 2 commits October 5, 2022 09:03

updated initialization and docstrings

450c7b2

test for user provided target simulator

e94a63c

JamesB-1qbit requested a review from ValentinS4t1qbit October 5, 2022 15:02

alexfleury-sb approved these changes Oct 5, 2022

View reviewed changes

JamesB-1qbit added 2 commits October 5, 2022 15:04

explicit support for None target

ea6ff73

class -> Factory function

51e49e8

ValentinS4t1qbit requested changes Oct 13, 2022

View reviewed changes

move expect function

d039720

ValentinS4t1qbit approved these changes Oct 13, 2022

View reviewed changes

ValentinS4t1qbit merged commit 25d5a58 into sandbox-quantum:develop Oct 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor simulator #213

Refactor simulator #213

JamesB-1qbit commented Sep 15, 2022 •

edited

Loading

ValentinS4t1qbit left a comment

ValentinS4t1qbit left a comment

ValentinS4t1qbit left a comment •

edited

Loading

alexfleury-sb left a comment •

edited

Loading

ValentinS4t1qbit left a comment •

edited

Loading

ValentinS4t1qbit left a comment

Refactor simulator #213

Refactor simulator #213

Conversation

JamesB-1qbit commented Sep 15, 2022 • edited Loading

ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

ValentinS4t1qbit left a comment • edited Loading

Choose a reason for hiding this comment

alexfleury-sb left a comment • edited Loading

Choose a reason for hiding this comment

ValentinS4t1qbit left a comment • edited Loading

Choose a reason for hiding this comment

ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

JamesB-1qbit commented Sep 15, 2022 •

edited

Loading

ValentinS4t1qbit left a comment •

edited

Loading

alexfleury-sb left a comment •

edited

Loading

ValentinS4t1qbit left a comment •

edited

Loading