Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dropdown is open, clicking dropdown is not closing #303

Closed
musasahinkundakci opened this issue Dec 5, 2023 · 9 comments
Closed

When dropdown is open, clicking dropdown is not closing #303

musasahinkundakci opened this issue Dec 5, 2023 · 9 comments

Comments

@musasahinkundakci
Copy link
Contributor

musasahinkundakci commented Dec 5, 2023

What i want to do is
Adding param like closeOnInputClick...

@musasahinkundakci
Copy link
Contributor Author

musasahinkundakci commented Dec 5, 2023

I think it would be great bcz,
from mobile perspective current behaviour not cool

@sanusart
Copy link
Owner

sanusart commented Dec 6, 2023

Hey. We already have

closeOnSelect

@musasahinkundakci
Copy link
Contributor Author

musasahinkundakci commented Dec 6, 2023

Hey. We already have

closeOnSelect

No this is for option selection,
On input click, it should be closable...
Like mobile apps.
The select html input supports it.

Think about it, you have a multi select input and 3 others.
small screen and a form....
Closing when u are selecting multiple option is hard.
Yeah closeOnSelect good for singleSelect
🤷🏼

@sanusart
Copy link
Owner

sanusart commented Dec 6, 2023 via email

@musasahinkundakci
Copy link
Contributor Author

musasahinkundakci commented Dec 6, 2023

Clicking outside + Clicking Input combination those are the examples.

Those component libraries select. components support Clicking outside + Clicking Input;
https://mui.com/material-ui/react-select/
https://ant.design/components/select

react-dropdown-select supports;

  • Supports click on option close
  • Supports close on click out side
  • Doesn't support click on input close...

@sanusart
Copy link
Owner

sanusart commented Dec 6, 2023 via email

@musasahinkundakci
Copy link
Contributor Author

Search mode of course behaviour will change,
closeOnInput click will be disabled.
And in the doc it should be dictated.
What i think

@sanusart
Copy link
Owner

sanusart commented Dec 6, 2023 via email

@musasahinkundakci
Copy link
Contributor Author

4.11.0
Released.
@sanusart Let's close this.

@sanusart sanusart closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants