Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 303 added closeOnClickInput support #304

Merged

Conversation

musasahinkundakci
Copy link
Contributor

@musasahinkundakci musasahinkundakci commented Dec 7, 2023

#303

If u are searching something closeOnClickInput will be disabled.
Gatsby project, README.md updated.
Tests are fine.

I didn't make it default true, because current live apps behaviour may change and not good.

Copy link

codesandbox-ci bot commented Dec 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f65c98e:

Sandbox Source
react-dropdown-select Configuration

@musasahinkundakci musasahinkundakci force-pushed the feat-303-close-on-click-dropdown branch 4 times, most recently from a2ba33c to 57ffa2a Compare December 7, 2023 08:30
@musasahinkundakci
Copy link
Contributor Author

Codacy Static Code Analysis
@sanusart Is it normal , take too much time ?

@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

@musasahinkundakci I think it is complaining:
https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

@musasahinkundakci
Copy link
Contributor Author

musasahinkundakci commented Dec 7, 2023

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm
Actually i was gonna add Common Models in the project...
But it s another context.

The props validations, in the Content component none of them were made u know.

But if u want i can do that.

under;

src/models/common.model.js

StateModelProps
MethodModelProps
PropsModelProps

Also why i said it is another context,
When we have this common model props.
We should add it to other sub components' props validations...

@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm Actually i was gonna add Common Models in the project... But it s another context.

The props validations, in the Content component none of them were made u know.

But if u want i can do that.

under;

src/models/common.model.js

StateModelProps MethodModelProps PropsModelProps

Also why i said it is another context, When we have this common model props. We should add it to other sub components' props validations...

Yes, I think models addition are out of scope for this, but lint still need to be fixed imho

@musasahinkundakci
Copy link
Contributor Author

@musasahinkundakci I think it is complaining: https://app.codacy.com/gh/sanusart/react-dropdown-select/pullRequest?prid=13195575

Hmm Actually i was gonna add Common Models in the project... But it s another context.
The props validations, in the Content component none of them were made u know.
But if u want i can do that.
under;
src/models/common.model.js
StateModelProps MethodModelProps PropsModelProps
Also why i said it is another context, When we have this common model props. We should add it to other sub components' props validations...

Yes, I think models addition are out of scope for this, but lint still need to be fixed imho

Cool, i'll fix that

@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

Amazing, I'll try to release ASAP after the merge as otherwise it looks great.

@musasahinkundakci musasahinkundakci force-pushed the feat-303-close-on-click-dropdown branch 2 times, most recently from 3fe2081 to 62d6383 Compare December 7, 2023 10:45
@musasahinkundakci
Copy link
Contributor Author

musasahinkundakci commented Dec 7, 2023

SelectMethodsModel
SelectPropsModel
SelectStateModel

are added.
I didn't want to push deficient commit.
At least now we have the models.

Later we can add them to other files.
Now other warnings :D
Well expected...

@musasahinkundakci musasahinkundakci force-pushed the feat-303-close-on-click-dropdown branch 5 times, most recently from 9b67bac to 7919866 Compare December 7, 2023 11:21
@musasahinkundakci
Copy link
Contributor Author

SelectMethodsModel SelectPropsModel SelectStateModel

are added. I didn't want to push deficient commit. At least now we have the models.

Later we can add them to other files. Now other warnings :D Well expected...

All good

@musasahinkundakci
Copy link
Contributor Author

SelectMethodsModel SelectPropsModel SelectStateModel
are added. I didn't want to push deficient commit. At least now we have the models.
Later we can add them to other files. Now other warnings :D Well expected...

All good

I'm gonna cry now :D

@musasahinkundakci
Copy link
Contributor Author

@sanusart I think there is a problem with code analysis.
Please could u check it manually ?

@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

Maybe it is complaining about == versus === while the prop is boolean?

@musasahinkundakci musasahinkundakci force-pushed the feat-303-close-on-click-dropdown branch from 7919866 to f65c98e Compare December 7, 2023 16:59
@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

I think I gonna merge it and see what with the typing later

@sanusart sanusart merged commit 6d9e37d into sanusart:master Dec 7, 2023
6 of 7 checks passed
@sanusart
Copy link
Owner

sanusart commented Dec 7, 2023

Released v4.11.0.

Thanks so much @musasahinkundakci !

@musasahinkundakci
Copy link
Contributor Author

Released v4.11.0.

Thanks so much @musasahinkundakci !

Np,
I liked ur extendable light-weight library :-)
Well done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants