-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 303 added closeOnClickInput support #304
Feat: 303 added closeOnClickInput support #304
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f65c98e:
|
a2ba33c
to
57ffa2a
Compare
Codacy Static Code Analysis |
@musasahinkundakci I think it is complaining: |
Hmm The props validations, in the Content component none of them were made u know. But if u want i can do that. under; src/models/common.model.js
Also why i said it is another context, |
Yes, I think models addition are out of scope for this, but lint still need to be fixed imho |
Cool, i'll fix that |
Amazing, I'll try to release ASAP after the merge as otherwise it looks great. |
3fe2081
to
62d6383
Compare
are added. Later we can add them to other files. |
9b67bac
to
7919866
Compare
All good |
I'm gonna cry now :D |
@sanusart I think there is a problem with code analysis. |
Maybe it is complaining about |
7919866
to
f65c98e
Compare
I think I gonna merge it and see what with the typing later |
Released v4.11.0. Thanks so much @musasahinkundakci ! |
Np, |
#303
If u are searching something
closeOnClickInput
will be disabled.Gatsby project, README.md updated.
Tests are fine.
I didn't make it default true, because current live apps behaviour may change and not good.