Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with SSR #66

Closed
ramraphael opened this issue Jan 29, 2020 · 3 comments
Closed

Incompatible with SSR #66

ramraphael opened this issue Jan 29, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed Regression

Comments

@ramraphael
Copy link

The core component seems to be adding event listeners on the window object without checking the environment it's being executing on, which causes errors in Node during SSR.
@sanusart
Copy link
Owner

It would be really helpful to see the errors, the snippet used that triggers error and in general more about the environment error is happening.
In order to try to reproduce as close as possible because I do not load it any ssr app.

@sanusart
Copy link
Owner

sanusart commented Feb 7, 2020

This is regression started after 3.6.3
Something changed in emotion used for styling

@sanusart sanusart added bug Something isn't working Regression help wanted Extra attention is needed labels Feb 7, 2020
sanusart added a commit that referenced this issue Feb 15, 2020
@sanusart
FIX (ssr) [#66]: incompatible with SSR closes #66
e1a882d
sanusart added a commit that referenced this issue Feb 15, 2020
@sanusart
FIX (ssr) [#66]: incompatible with SSR, test with target node closes #66
68fbbf8
sanusart added a commit that referenced this issue Feb 15, 2020
@sanusart
FIX (ssr) [#66]: incompatible with SSR
4149d35
@sanusart
Copy link
Owner

Fix version: 4.0.0

sanusart added a commit that referenced this issue Mar 27, 2020
@sanusart
Merge remote-tracking branch 'origin/master' into next
ba4b4c4 
* origin/master:
  v4.2.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FEATURE (props): add onDropdownCloseRequest prop to notify about clos… (#80)
  v4.1.1 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (types): types improvement by @435352980 closes #76
  v4.1.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  Fixed an issue where top positioning would not work in portal mode (#77) closes #73 Thanks to @akdjr
  FIX (changelog): update changelog
  v4.0.1 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (props): fix prop type warnings (#75) thanks to @kkkrist
  DOCS (docs): fix docs and update packages
  FIX (ssr) [#66]: incompatible with SSR closes #66 (#72)
  CHORE (cleanup): cleanup unused
  v3.12.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FEATURE (events) [#70]: Remove selected option on key press of backspace button, closes #70 (#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanusart @ramraphael