Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX (props): fix prop type warnings #75

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Conversation

kkkrist
Copy link
Contributor

@kkkrist kkkrist commented Feb 24, 2020

  • use defaultValue instead of value in hidden input, so that React won't complain about missing onChange handler
  • fix initial value for pattern prop

resolves #74

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 84540b3:

Sandbox Source
react-dropdown-select Configuration

@sanusart sanusart merged commit b7429cf into sanusart:master Feb 24, 2020
sanusart added a commit that referenced this pull request Mar 27, 2020
* origin/master:
  v4.2.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FEATURE (props): add onDropdownCloseRequest prop to notify about clos… (#80)
  v4.1.1 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (types): types improvement by @435352980 closes #76
  v4.1.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  Fixed an issue where top positioning would not work in portal mode (#77) closes #73 Thanks to @akdjr
  FIX (changelog): update changelog
  v4.0.1 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (props): fix prop type warnings (#75) thanks to @kkkrist
  DOCS (docs): fix docs and update packages
  FIX (ssr) [#66]: incompatible with SSR closes #66 (#72)
  CHORE (cleanup): cleanup unused
  v3.12.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FEATURE (events) [#70]: Remove selected option on key press of backspace button, closes #70 (#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden input triggers "value prop without an onChange handler" prop type error
2 participants