Goreleaser #133
Merged
Goreleaser #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
approved these changes
Oct 6, 2023
| 1. Ensure local `master` branch is up to date with `origin/master`: | ||
|
|
||
| ```sh | ||
| git fetch --tags && git pull --tags |
There was a problem hiding this comment.
Suggested change
| git fetch --tags && git pull --tags | |
| git fetch --all --tags --prune && git pull --tags |
|
|
||
| ```sh | ||
| git tag vX.Y.Z | ||
| git push --tags |
There was a problem hiding this comment.
Suggested change
| git push --tags | |
| git push | |
| git push --tags |
we want to make sure the commit is on the branch
go-makefile-maker adds the required instructions to generate release-info to the GoReleaser workflow, there is no need for a Makefile rule.
and remove explicit `arch` definition for platform.
SuperSandro2000
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before sapcc/go-makefile-maker#122
FYI @SuperSandro2000 @VoigtS