GoReleaser: remove Homebrew Tap from config #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and: - use `createConfig` for option key as it conveys the intent better similiar to `golangciLint.createConfig`. - use `.yaml` for file extension in order to be consistent with GitHub workflow and golangci-lint config files.
talal
force-pushed
the
GoReleaser-update
branch
from
758c0c8 to
2a6324a
Compare
so that we don't have to add a corresponding verbatim section in the `Makefile.maker.yaml` file.
This was referenced Oct 6, 2023
This reverts commit d937499.
|
I have actually started this locally, too but I can rebase mine on top of yours afterwards. |
SuperSandro2000
approved these changes
Oct 6, 2023
Comment on lines
+40
to
+43
| Run: makeMultilineYAMLString([]string{ | ||
| "go install github.com/sapcc/go-bits/tools/release-info@latest", | ||
| "release-info CHANGELOG.md $(shell git describe --tags --abbrev=0) > build/release-info", | ||
| }), |
There was a problem hiding this comment.
less abstraction layers make totally sense here 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and:
createConfigfor option key as it conveys the intent better similiar togolangciLint.createConfig..yamlfor file extension in order to be consistent with GitHub workflow and golangci-lint config files.