easypg: replace testing/with-postgres-db.sh with a Go API #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
majewsky
force-pushed
the
easypg-better-test-mode
branch
from
d13bb4b to
dab5953
Compare
I want to be able to carry these independently because tests want to use a different logic for obtaining a database URL while still using the same Configuration as the productive code otherwise.
This replaces the shell script `./testing/with-postgres-db.sh`. The new test server is completely separate from the one managed by the script (it uses a different data directory and also a different port number), so it can be run in parallel with the old script until all usage has been ported over. Then we can remove the shell script from go-makefile-maker.
majewsky
force-pushed
the
easypg-better-test-mode
branch
from
dab5953 to
3c4df7c
Compare
VoigtS
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test server is completely separate from the one managed by the script (it uses a different data directory and also a different port number), so it can be run in parallel with the old script until all usage has been ported over. Then we can remove the shell script from go-makefile-maker.
I have tested this by porting Castellum to this new version of the library. This can be inspected in sapcc/castellum@fda9392.