Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install postgresql-17 package in test job if necessary #218

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

majewsky
Copy link
Contributor

This opens a migration path for moving to the new version of github.com/sapcc/go-bits/easypg (sapcc/go-bits#189). The DB service on port 54321 can be used before migration, and the installed DB package can be used after migration on port 54320.

This opens a migration path for moving to the new version of
`github.com/sapcc/go-bits/easypg`. The DB service on port 54321 can be
used before migration, and the installed DB package can be used after
migration on port 54320.
@coveralls
Copy link

Coverage Status

coverage: 4.146%. remained the same
when pulling 95a4ef2 on easypg-migration-path
into 3542f2d on main.

"sudo apt-get install --no-install-recommends postgresql-" + core.DefaultPostgresVersion,
fmt.Sprintf("export PATH=/usr/lib/postgresql/%s/bin:$PATH", core.DefaultPostgresVersion),
}, testCmd...)
// TODO remove this service once all users migrated to use github.com/sapcc/go-bits/easypg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't easily detect this. A shame.

@majewsky majewsky merged commit e6329e4 into main Dec 12, 2024
6 checks passed
@majewsky majewsky deleted the easypg-migration-path branch December 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants