Add goreleaser enterprise config #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuckal777
requested review from
majewsky,
SuperSandro2000 and
VoigtS
as code owners
majewsky
requested changes
Sep 4, 2024
| @@ -58,4 +71,10 @@ func releaseWorkflow(cfg core.Configuration) { | |||
| w.Jobs = map[string]job{"release": j} | |||
|
|
|||
| writeWorkflowToFile(w) | |||
| isInternal := strings.HasPrefix(cfg.Metadata.URL, "https://github.wdf.sap.corp") | |||
There was a problem hiding this comment.
I would like this to not hardcode a specific GHE instance. Can we have it match on a domain that is not github.com, and then use the hostname to construct the URLs that appear in the goreleaser config?
Nuckal777
force-pushed
the
goreleaser-config
branch
from
cd32590 to
185324f
Compare
Nuckal777
force-pushed
the
goreleaser-config
branch
from
7fa4356 to
d846b1a
Compare
|
Turns out we already have this at https://github.com/sapcc/go-makefile-maker/blob/main/internal/goreleaser/goreleaser.go 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.