Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major versions are not properly split when passed in as floats #59

Closed
techalchemy opened this issue Jan 22, 2019 · 0 comments
Closed

Major versions are not properly split when passed in as floats #59

techalchemy opened this issue Jan 22, 2019 · 0 comments
Assignees
@techalchemy
Labels
bug Something isn't working

Comments

@techalchemy
Copy link
Member

For instance, pythonfinder.find_python_version('3.7') fails due to attempts to cast the string to an integer.

This needs to be gracefully handled
@techalchemy techalchemy self-assigned this Jan 22, 2019
@techalchemy techalchemy added the bug Something isn't working label Jan 22, 2019
techalchemy added a commit that referenced this issue Jan 22, 2019
@techalchemy
Parse numeric version inputs using RE parser
6e4d5c9 
- Uses existing parser built for handling complex versions
- Is sufficiently robust, should handle most circumstances
- Fixes #59
- Closes and supersedes #57

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Jan 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@techalchemy