Fix cast to int via using casting to float first #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int("3.7") will give you an ValueError on the other hand whenever you cast it to float then cast it to int will fix this problem so to overcome simular issues it will be much secure to use int(float(... system
|
Hey, thanks for the PR -- i missed this some time ago but would you mind letting me know where you're running into this? The code is kind of messy as is and I'd prefer to avoid making it messier if possible. Ideally we would do that by not passing floats in the first place |
|
Ah I see the issue, I believe I have a different approach for this |
|
(closed by #60 -- thanks again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int("3.7") will give you an ValueError on the other hand whenever you cast it to float then cast it to int will fix this problem so to overcome simular issues it will be much secure to use int(float(... system