Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct notation for multiple denominator units #2375

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

Goodwine
Copy link
Member

@Goodwine Goodwine commented Oct 2, 2024

@nex3
Copy link
Contributor

nex3 commented Oct 2, 2024

I'm not entirely convinced this is better. We can't realistically match the SI standards here—I don't think users would really understand px*em⁻¹*rad⁻¹*s⁻¹ even if we could rely on Unicode characters rendering well everywhere. px*em/rad/s is explicitly called out as not recommended. We could do px*em/(rad*s), which does seem to be one of the allowed SI formats and is more clear to a naive reader.

@Goodwine
Copy link
Member Author

Goodwine commented Oct 2, 2024

Oops, I only skimmed through the doc and didn't actually read it lol

I like using parentheses in this case, I'll update the PR

CHANGELOG.md Outdated Show resolved Hide resolved
@Goodwine Goodwine merged commit 2c5f1e9 into main Oct 10, 2024
38 checks passed
@Goodwine Goodwine deleted the denominator branch October 10, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants