Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct notation for multiple denominator units #2375

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Use correct notation for multiple denominator units #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcebdd9
Use correct notation for multiple denominator units
Goodwine Oct 2, 2024
80af31f
format
Goodwine Oct 2, 2024
7809493
versions and changelog
Goodwine Oct 2, 2024
0a34918
use parentheses
Goodwine Oct 2, 2024
78f4280
format
Goodwine Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
* Fix a slight inaccuracy case when converting to `srgb-linear` and
`display-p3`.

* **Potentially breaking bug fix:** `math.unit()` now wraps multiple denominator
units in parentheses. For example, `px/(em*em)` instead of `px/em*em`.

### JS API

* Fix `SassColor.interpolate()` to allow an undefined `options` parameter, as
Expand Down
3 changes: 2 additions & 1 deletion lib/src/value/number.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,8 @@ abstract class SassNumber extends Value {
([], [var denominator]) => "$denominator^-1",
([], _) => "(${denominators.join('*')})^-1",
(_, []) => numerators.join("*"),
_ => "${numerators.join("*")}/${denominators.join("*")}"
(_, [var denominator]) => "${numerators.join("*")}/$denominator",
_ => "${numerators.join("*")}/(${denominators.join("*")})",
};

bool operator ==(Object other) {
Expand Down