Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong :before position #3084

Closed
ahorek opened this issue Apr 30, 2020 · 2 comments · Fixed by #3086
Closed

wrong :before position #3084

ahorek opened this issue Apr 30, 2020 · 2 comments · Fixed by #3086
Assignees
Labels

Comments

@ahorek
Copy link
Contributor

ahorek commented Apr 30, 2020

Hi, was this change intentional or is it a bug? Probably it's not a bug, but I just want to be sure.

input.scss

.red-icon {
  color: #e50026;
}

a.nested:before {
  &.error {
    @extend .red-icon;
  }
}

Actual results

libsass 3.6.3

.red-icon, a.nested:before.error {
  color: #e50026; }

dart sass also have this behavior

in this case <div class="red-icon">text</div> isn't red.

Expected result

libsass 3.6.1

.red-icon, a.nested.error:before {
  color: #e50026; }
@mgreter
Copy link
Contributor

mgreter commented Apr 30, 2020

Can you please open an issue with dart-sass since you established it has the same issue?

@mgreter
Copy link
Contributor

mgreter commented Apr 30, 2020

Note that the extend is not even needed, minimal reproduction also with:

:before {
    &.red-icon {
        foo: bar;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants