-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure correct output order of compound selectors #3086
Conversation
931833c
to
8ad5daf
Compare
I am going to merge this, as I have some time at hand right now to make a release. Even though knowing it will fail CI, but I cant merge the changes in sass-spec. But I'm certain this is an improvement in the right direction; why not emitting correct css selector when we can. Maybe dart-sass comes up with a different approach than to ensure the order on output. Note to myself: It might be worthwhile to check if we can integrate id and type selectors directly into the CompoundSelector, since css only allows to have one of each per compound selector. I already did the same for |
thanks for the release @mgreter ! |
No problem @ahorek, still quite a few steps to do for a complete release :) |
This breaks compatibility with Dart Sass and with the specified behavior of Sass. Please roll back for now. If you want to propose a change to the language itself, you need to follow the language change process. |
Given the discussion in sass/dart-sass#996 we'll need to revert this PR. As @nex3 this is change to the Sass language and makes us non-compliant. Embedders like Node Sass are now blocked on updating LibSass at the risk of introduce incompatible Sass code into the ecosystem. |
Fixes #3084, Needs sass/sass-spec#1529
I believe this will fail quite a few spec tests, since it seems we havesome of these as expected outputs!? Lets check what CI returns.
Opened PR to address this in sass-spec.