Skip to content
This repository has been archived by the owner on May 28, 2018. It is now read-only.

Added the Windows binaries for libsass v1.0.1 #2

Merged
merged 1 commit into from
Jan 10, 2014
Merged

Added the Windows binaries for libsass v1.0.1 #2

merged 1 commit into from
Jan 10, 2014

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@nschonni
Copy link
Contributor

👍
Just confirming that you didn't actually use the libsass 1.0.1 tag as it is older than what we need for sourcemaps

@LaurentGoderre
Copy link
Contributor Author

I'm building from the node-sass repo and it's submodule, which ATM seems to point to v1.0.1

@nschonni
Copy link
Contributor

😦 Sorry, you're right. I must have been thinking of the 1.0.0 tag. Unless sass/libsass#121 is happening again

:shipit:

nschonni added a commit that referenced this pull request Jan 10, 2014
Added the Windows binaries for libsass v1.0.1
@nschonni nschonni merged commit b3864ed into sass:master Jan 10, 2014
@LaurentGoderre
Copy link
Contributor Author

Man configuring VS and gyp is painfull but I think I figure it out

@LaurentGoderre LaurentGoderre deleted the libsass-v1.0.1-windows branch January 10, 2014 20:41
@nschonni
Copy link
Contributor

Yeah, I've been trying to figure out what other flags might be required for the binding.gyp.

Hopefully by next release I'll have figured out https://github.com/nodejitsu/module-foundry and we won't have to worry about it

@LaurentGoderre
Copy link
Contributor Author

Is that module build on gyp?

@nschonni
Copy link
Contributor

Yeah, just native module building as a service

@LaurentGoderre
Copy link
Contributor Author

Good luck to theme making it work for Windows....

@nschonni
Copy link
Contributor

Microsoft is one of the companies behind the project

@LaurentGoderre
Copy link
Contributor Author

Good to know!!

@andrew
Copy link
Contributor

andrew commented Jan 10, 2014

Thanks for this @LaurentGoderre, last time I updated libsass it was to the current head of master, I didn't notice if they are actually doing proper releases now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants