Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Update libsass to fix #132 and #189 #190

Closed
TomGault opened this issue Dec 11, 2013 · 13 comments
Closed

Update libsass to fix #132 and #189 #190

TomGault opened this issue Dec 11, 2013 · 13 comments

Comments

@TomGault
Copy link

#132 and duplicate issue #189 were closed because the problem was with libsass, not node-sass. Well, libsass now claims that sass/libsass#154 is now fixed so we should update our submodule to get the fix.

@jhollingworth
Copy link

👍

@deanmao
Copy link
Contributor

deanmao commented Jan 3, 2014

This should be fixed as libsass has been recently updated to today's master branch. Of course, it may take a few days for @andrew to publish a new set of binaries, but I will close out this issue for now.

@deanmao deanmao closed this as completed Jan 3, 2014
@ericjorgensen
Copy link

Any chance that this will be updated soon?

@andrew
Copy link
Contributor

andrew commented Jan 10, 2014

Mainly waiting on a windows binary, hopefully I'll be able to get a release out this weekend.

@ericjorgensen
Copy link

That would be amazing. Thanks!

@LaurentGoderre
Copy link
Contributor

No pressure huh! ;) The only holdup is the 32 bit version which won't compile for some reason.

@LaurentGoderre
Copy link
Contributor

There you go! sass/node-sass-binaries#2

@deanmao
Copy link
Contributor

deanmao commented Jan 10, 2014

How do windows binaries get built? Is there such thing as a windows build machine?

@LaurentGoderre
Copy link
Contributor

For the meantime I build them....

@andrew
Copy link
Contributor

andrew commented Jan 10, 2014

I wish there was a windows build machine!

@andrew
Copy link
Contributor

andrew commented Jan 11, 2014

@ericjorgensen
Copy link

You, sir, are a prince!

@andrew
Copy link
Contributor

andrew commented Jan 11, 2014

@ericjorgensen it's thanks to lots of help from @nschonni, @LaurentGoderre and @deanmao

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants