Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Recycle Bin in the Content Pane #152

Closed
boyce-w opened this issue Mar 8, 2023 · 3 comments
Closed

Support Recycle Bin in the Content Pane #152

boyce-w opened this issue Mar 8, 2023 · 3 comments
Assignees
@boyce-w
Labels
feature request New feature or request verification-needed

Comments

@boyce-w
Copy link
Contributor

boyce-w commented Mar 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is split from #109 :
File deletion: Right now, deleting a file permanently deletes it from SAS. In this issue, we'll want to implement the Recycle Bin functionality that is currently part of SAS drive (look for TODO #109 in the project's code)

Describe the solution you'd like

  • In the content navigation pane, add a top level folder Recycle Bin
  • Change the 'Delete' action of normal file/folder to move it to the Recycle Bin.
  • The Recycle Bin has a context menu item 'Empty Recycle Bin' to delete all the files/folders in the Recycle Bin permanently
  • The files/folders in the Recycle has a context menu which has 2 menu items 'Restore' and 'Delete'
  • The file in the Recycle Bin is supposed to be opened in read only mode
  • The file is supposed to be closed when it's moved to the recycle bin, deleted permanently, or restored from the recycle bin.

Environment
SAS Viya
@boyce-w boyce-w added the feature request New feature or request label Mar 8, 2023
@boyce-w boyce-w self-assigned this Mar 8, 2023
@boyce-w boyce-w mentioned this issue Mar 8, 2023
Closed
boyce-w added a commit to boyce-w/vscode-sas-extension that referenced this issue Mar 20, 2023
@boyce-w
feat: support recycle bin in content navigation sassoftware#152
9177b33
@boyce-w boyce-w mentioned this issue Mar 20, 2023
Closed
@boyce-w boyce-w assigned liu-lihua and unassigned boyce-w Mar 20, 2023
@liu-lihua liu-lihua assigned liu-lihua and Zhirong2022 and unassigned liu-lihua Mar 20, 2023
@Zhirong2022
Copy link
Collaborator

@skyeaussie , @crlewi Could you take some time on your convenience to check the concerns below？
Some concerns towards the file/folder in Recyble bin folder.

  1. Is it neccessary to prompt some sort of message dialog to ask the user to confirm the delete action if trying to delete a file/folder?
  2. Is it neccessry to ask the user to confirm 'Empty Recycle Bin' ?

@crlewi
Copy link
Collaborator

crlewi commented Mar 22, 2023 •
edited
Loading

@Zhirong2022

  1. Deleting files or folders from the content tree does not need a confirmation
  2. Permanently deleting items from the recycle bin should have confirmation messages.

A. Single item selected warning dialog with title of "Delete" and Delete and Cancel buttons:
Are you sure you want to permanently delete the item ""?

B. Multiple items selected warning dialog with title of "Delete" and Delete and Cancel buttons:
Are you sure you want to permanently delete the selected items?

C. Empty recycle bin warning dialog with title of "Empty Recycle Bin" and Delete and Cancel buttons:
Are you sure you want to permanently delete all the items? You cannot undo this action.

boyce-w added a commit to boyce-w/vscode-sas-extension that referenced this issue Mar 24, 2023
@boyce-w
feat: support recycle bin in content navigation sassoftware#152
85ccc60
boyce-w added a commit to boyce-w/vscode-sas-extension that referenced this issue Mar 24, 2023
@boyce-w
feat: support recycle bin in content navigation sassoftware#152
ca27256
@boyce-w boyce-w mentioned this issue Mar 24, 2023
Merged
boyce-w added a commit to boyce-w/vscode-sas-extension that referenced this issue Apr 3, 2023
@boyce-w
feat: support recycle bin in content navigation sassoftware#152
d828891
boyce-w added a commit that referenced this issue Apr 6, 2023
@boyce-w
feat: support recycle bin in content navigation #152 (#190)
6befa75 
* feat: support recycle bin in content navigation #152
* add modal confirmation notification before delete item permanently or empty recycle bin
* sync the file content when it was recycled
* delete resource instead of member
* always fetch etag before rename
@boyce-w
Copy link
Contributor Author

boyce-w commented Apr 6, 2023

fix pushed and close this feature

@boyce-w boyce-w closed this as completed Apr 6, 2023
@2TomLi 2TomLi assigned boyce-w and unassigned Zhirong2022 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boyce-w boyce-w

Labels
feature request New feature or request verification-needed
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

feat-152 boyce-w/vscode-sas-extension
4 participants
@crlewi @boyce-w @liu-lihua @Zhirong2022