-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support recycle bin in content navigation #152 #176
Conversation
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.17.11 to 0.17.12. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.17.11...v0.17.12) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.2. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.2) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.54.1 to 5.55.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.55.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.4 to 2.8.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.4...2.8.5) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.0.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.9.5...v5.0.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
**Summary** This fixes an issue where session invalidation caused issues with displaying files and folders (see sassoftware#163). This addresses the issue by triggering a reconnect when a 401 (Unauthorized) error is encountered. **Testing** - Tested using SAS content as one normally would - Left the extension unattended for several hours, and made sure SAS content was refreshed
Acceptance Criteria: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far. I appreciate you taking this one on :)
const actions = [ | ||
addMember && !isRecycled ? "createChild" : undefined, | ||
del ? "delete" : undefined, | ||
write && !isRecycled ? "update" : undefined, | ||
write && isRecycled ? "restore" : undefined, | ||
].filter((action) => !!action); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks a little complicated. I made an effort to uncomplicate it a little, but my code is relying on javascript trickery which I don't love...
const actions = [ | |
addMember && !isRecycled ? "createChild" : undefined, | |
del ? "delete" : undefined, | |
write && !isRecycled ? "update" : undefined, | |
write && isRecycled ? "restore" : undefined, | |
].filter((action) => !!action); | |
const actions = [ | |
addMember && !isRecycled && "createChild", | |
del && "delete", | |
write && !isRecycled && "update", | |
write && isRecycled && "restore", | |
].filter((action) => !!action); |
In any case, this is a challenge to read at first glance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all to say, you can leave your code as-is, or if you see a good way to make it a little more readable, that'd be awesome, too :)
…ssoftware#162) * fix: improve the new file/folder name validator (sassoftware#156)
* fix: reset ready timeout on success * feat: sinon types * add sinon types to aid with type safety * refactor contentdataprovider tests to use types * add ts-sinon library to add with stubbing of interfaces * add unit tests for ssh connection provider * remove only function from ssh suite * stub axios interceptor * fix: use stream.close when closing session * use arrow functions * visibility modifiers on class functions * refactor listeners into discreet methods * Update client/test/connection/ssh/index.test.ts Co-authored-by: Scott Dover <scott@scottdover.com> * Update client/test/connection/ssh/index.test.ts Co-authored-by: Scott Dover <scott@scottdover.com> --------- Co-authored-by: Scott Dover <scott@scottdover.com>
I don't know why this branch goes wrong after I rebased the PR and resolved the conflicts. It contains the commits pushed in the main branch and the changed files are contaminated. So I created a new PR #190 and close this one. Sorry for confusing. |
Since the issue is Dup to PR#190, verify it as well. |
Summary
Support Recycle Bin in the SAS Content Navigation Pane.
See details in the issue #152
Testing
How did you test this change?
Test manually and run all the unit tests