WRONG_INDENTATION: running mvn diktat:fix adds whitespace to string literals

[0x6675636b796f75676974687562]

Consider this code fragment:

    @Test
    fun `checking that suppression with ignore everything works`() {
        val code =
                """
                    @Suppress("diktat")
                    fun foo() {
                        val a = 1
                    }
                """.trimIndent()
        lintMethod(code)
    }

Whenever the code doesn't match the settings of DiKTat (i.e., in the above example, the body of the code expression uses continuation indent while extendedIndentAfterOperators is false), running mvn diktat:fix is expected to re-format the code.

While doing so (particularly, when WRONG_INDENTATION check is on), it sometimes adds extra whitespace around and within string literals, i. e.

                    @Suppress("diktat")

may become

                    @Suppress(    "    diktat    "    )

Moreover, the operation is not idempotent, so running mvn diktat:fix consecutively yet increases the amount of whitespace.

Sometimes excessively long lines get wrapped, and this may even result in non-compilable code:

                    @Suppress(    "    diktat
    "    )

Screenshot:

Originally from this comment.

[0x6675636b796f75676974687562]

Another example (from #811):

fun checkScript() {
    lintMethod(
            """
                        |val A = "aa"
                    """.trimMargin(),
    )
}

[0x6675636b796f75676974687562]

Originally introduced with the fix for #766.

The problem is caused by the wrong assumption that there can be no more than two LITERAL_STRING_TEMPLATE_ENTRY nodes per a single line in a STRING_TEMPLATE (the 1st one not terminated with a newline and the last one newline-terminated).

Actually, there can be more, e.g., the 1st line in this literal:

        """
            @Suppress("diktat")
            fun foo() {
                val a = 1
            }
        """.trimIndent()

— which is @Suppress("diktat"), consists of LITERAL_STRING_TEMPLATE_ENTRY nodes:

1. @Suppress(
2. "
3. diktat
4. "
5. )

All these nodes get indented via IndentationRule#fixFirstTemplateEntries.

[petertrr]

@0x6675636b796f75676974687562 looks like this issues has been incorrectly closed by Github automation, because commit message contained fix #1347?

[0x6675636b796f75676974687562]

@0x6675636b796f75676974687562 looks like this issues has been incorrectly closed by Github automation, because commit message contained fix #1347?

Indeed, despite I was sure I changed the commit message.
Thanks for the heads-up.
Reopening.