[#1347] Indent only TEMPLATE_ENTRY nodes immediately following a newline
#1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wline ### What's done: * Now, only those `LITERAL_STRING_TEMPLATE_ENTRY` nodes which immediately follow a newline are indented. * Additionally, with this change, `trimIndent()` and `trimMargin(...)` calls are more reliably detected. * This fixes #1347.
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
============================================
- Coverage 83.43% 83.30% -0.13%
+ Complexity 2555 2554 -1
============================================
Files 107 107
Lines 7557 7565 +8
Branches 2087 2090 +3
============================================
- Hits 6305 6302 -3
- Misses 368 373 +5
- Partials 884 890 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0x6675636b796f75676974687562
added
autofix
orchestr7
reviewed
Jun 21, 2022
...at-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationRuleTestMixin.kt
Show resolved
Hide resolved
orchestr7
reviewed
Jun 21, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Outdated
Show resolved
Hide resolved
orchestr7
approved these changes
Jun 21, 2022
|
lgtm |
…wline ### What's done: * Minor code clean-up.
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
LITERAL_STRING_TEMPLATE_ENTRYnodes which immediatelyfollow a newline are indented.
trimIndent()andtrimMargin(...)callsare more reliably detected.
WRONG_INDENTATION: runningmvn diktat:fixadds whitespace to string literals #1347.Actions checklist