Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A full path in gradle plugin output #1795

Closed
nulls opened this issue Nov 14, 2023 · 0 comments · Fixed by #1798
Closed

A full path in gradle plugin output #1795

nulls opened this issue Nov 14, 2023 · 0 comments · Fixed by #1798
Assignees
@nulls
Milestone
2.0.0

Comments

@nulls
Copy link
Member

nulls commented Nov 14, 2023

Old logs:

> Task :diktatCheck
D:\projects\save-cloud\gradle\plugins\build.gradle.kts:30:1: [WRONG_INDENTATION] only spaces are allowed for indentation and each indentation should equal to 4 spaces (tabs are not allowed): expected 8 but was 4 (diktat-ruleset:indentation)
D:\projects\save-cloud\gradle\plugins\build.gradle.kts:31:1: [WRONG_INDENTATION] only spaces are allowed for indentation and each indentation should equal to 4 spaces (tabs are not allowed): expected 4 but was 0 (diktat-ruleset:indentation)
D:\projects\save-cloud\gradle\plugins\build.gradle.kts:31:1: [COMMENT_WHITE_SPACE] there should be a white space between code and comment also between code start token and comment text: There should be 1 space(s) before comment token in //    implementation(libs.gradle.plugin.spotless) (diktat-ruleset:kdoc-comments-codeblocks-formatting)

Current logs:

> Task :diktatCheck
gradle\plugins\build.gradle.kts:30:1: [WRONG_INDENTATION] only spaces are allowed for indentation and each indentation should equal to 4 spaces (tabs are not allowed): expected 8 but was 4 (diktat-ruleset:indentation)
gradle\plugins\build.gradle.kts:31:1: [WRONG_INDENTATION] only spaces are allowed for indentation and each indentation should equal to 4 spaces (tabs are not allowed): expected 4 but was 0 (diktat-ruleset:indentation)
gradle\plugins\build.gradle.kts:31:1: [COMMENT_WHITE_SPACE] there should be a white space between code and comment also between code start token and comment text: There should be 1 space(s) before comment token in //    implementation(libs.gradle.plugin.spotless) (diktat-ruleset:kdoc-comments-codeblocks-formatting)

IDEA renders a full path as a link that is useful
@nulls nulls added this to the 2.0.0 milestone Nov 14, 2023
@nulls nulls self-assigned this Nov 14, 2023
nulls added a commit that referenced this issue Nov 14, 2023
@nulls
Support a full path in DiktatReporter
e219dff 
### What's done:
- supported sourceRootDir as null in DiktatReporter
- pass sourceRootDir as null in gradle plugin

It closes #1795
@nulls nulls mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Support a full path in DiktatReporter saveourtool/diktat
1 participant
@nulls