Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a full path in DiktatReporter #1798

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Support a full path in DiktatReporter #1798

merged 8 commits into from
Nov 15, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 14, 2023

What's done:

  • supported sourceRootDir as null in DiktatReporter
  • pass sourceRootDir as null in gradle plugin

It closes #1795

@nulls
Support a full path in DiktatReporter
e219dff 
### What's done:
- supported sourceRootDir as null in DiktatReporter
- pass sourceRootDir as null in gradle plugin

It closes #1795
@nulls nulls self-assigned this Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   6m 22s ⏱️ - 4m 22s
1 395 tests ±0  1 359 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
2 774 runs  ±0  2 738 ✔️ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 69e30d9. ± Comparison against base commit 303f006.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files  ±0     165 suites  ±0   6m 59s ⏱️ - 6m 7s
1 395 tests ±0  1 378 ✔️ ±0  17 💤 ±0  0 ❌ ±0 
2 774 runs  ±0  2 757 ✔️ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit a6d2499. ± Comparison against base commit 7b7d2b6.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (303f006) 78.41% compared to head (69e30d9) 78.38%.

Files Patch % Lines
...ourtool/diktat/ktlint/DiktatBaselineFactoryImpl.kt 0.00% 5 Missing ⚠️
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 2 Missing ⚠️
...om/saveourtool/diktat/ktlint/DiktatReporterImpl.kt 0.00% 2 Missing ⚠️
...otlin/com/saveourtool/diktat/ktlint/KtLintUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1798      +/-   ##
============================================
- Coverage     78.41%   78.38%   -0.04%     
  Complexity     2420     2420              
============================================
  Files           126      126              
  Lines          8466     8470       +4     
  Branches       2147     2149       +2     
============================================
  Hits           6639     6639              
- Misses          867      871       +4     
  Partials        960      960

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nulls nulls marked this pull request as ready for review November 15, 2023 10:47
@nulls nulls merged commit 0c7ed43 into master Nov 15, 2023
19 of 21 checks passed
@nulls nulls deleted the feature/full-path-reporter#1795 branch November 15, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgevorkyan kgevorkyan kgevorkyan approved these changes

Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A full path in gradle plugin output
2 participants
@nulls @kgevorkyan