Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package to com.github.sbt.git #217

Closed
wants to merge 1 commit into from
Closed

Conversation

raboof
Copy link
Collaborator

@raboof raboof commented Mar 16, 2022

To prevent classpath problems when it is on the same classpath with the sbt-git when it was published with the old

Not for merge yet: need to check whether having 'overlapping' autoplugins confuses sbt.

Refs #216

To prevent classpath problems when it is on the same classpath with
the sbt-git when it was published with the old

Refs sbt#216
@raboof
Copy link
Collaborator Author

raboof commented Mar 16, 2022

This indeed breaks: created a project with plugins.sbt like

addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.10")

// From https://github.com/sbt/sbt-git/pull/217
addSbtPlugin("com.github.sbt" % "sbt-git" % "1.0.3-M1+6-96835fcb-SNAPSHOT")

Produced:

[error] Some keys were defined with the same name but different types: 'gitReader' (com.github.sbt.git.ReadableGit, com.typesafe.sbt.git.ReadableGit), 'gitRunner' (sbt.Task[com.typesafe.sbt.git.GitRunner], sbt.Task[com.github.sbt.git.GitRunner])
[error] Use 'last' for the full log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant