Change package to com.github.sbt.git
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent classpath problems when it is on the same classpath with the sbt-git when it was published with the old Refs sbt#216
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #217, just so there is at least one path forward.
#216 discusses some ideas to publish a transitional artifact under the old group id, but I don't how hard that would be and/or who can do that, since this repo is now setup for CI release on the new group id.
#217 notes that if the old/new version of the plugin end up on the same build, the build will break. But that's not the end of the world: it's no different than a fatal eviction error due to a version incompatibility. In any case, it's better than non-determinate behavior if the package was kept the same.
IMO if it's possible to keep publishing to the old group id, instead of trying to do a transitional-artifact-hack the plugin should consider to continue publishing under the old group id since that would avoid this whole mess. The switch to the new group id can happen concurrently to the breaking update to JGit 6 in #213.