support sbt 1.0 #107
Merged
support sbt 1.0 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Laika is almost there, but happy to file a pull request after a release of sbt-site. sbt-site is sufficiently important to get going, even with a reduced feature set. |
xuwei-k
commented
Aug 11, 2017
| Map("version" -> binV, "release" -> version) | ||
| } | ||
|
|
||
| def installPackagesTask = Def.task { | ||
| val runner = sphinxRunner.value | ||
| val packages = sphinxPackages.value | ||
| val s = streams.value | ||
| packages map { p => runner.installPackage(p, target.value, s.log) } | ||
| val t = target.value |
There was a problem hiding this comment.
6 tasks
jonas
approved these changes
Aug 12, 2017
|
|
||
| addSbtPlugin("org.planet42" % "laika-sbt" % "0.7.0") | ||
| libraryDependencies ++= { | ||
| if((sbtVersion in pluginCrossBuild).value.startsWith("0.13")) { |
There was a problem hiding this comment.
👍 Laika and Paradox are fairly new additions.
| val excludeTests = tests.map(_._2).toSet | ||
| (file("src/sbt-test") / g).listFiles.map(_.getName).filterNot(excludeTests).map(g + "/" + _) | ||
| }.toList | ||
| val args = (runAll ++ runPartial).mkString(" ", " ", "") |
There was a problem hiding this comment.
Really nice, I didn't know this was possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{scala => scala-sbt-0.13}/com/typesafe/sbt/site/laika/LaikaSitePlugin.scala,{scala => scala-sbt-0.13}/com/typesafe/sbt/site/paradox/ParadoxSitePlugin.scalabecause laika and paradox does not support sbt 1.0 yet. ( [WIP] Cross build using sbt 0.13.16 #102 (comment) )I think we should release for sbt 1.0 without
LaikaSitePluginandParadoxSitePlugin.fix #105