Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind dark variant working #810

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Tailwind dark variant working #810

merged 1 commit into from
Apr 12, 2024

Conversation

carletex
Copy link
Member

Tailwind offers the dark variant (same as hover:, etc) https://tailwindcss.com/docs/dark-mode, but it didn't work because we didn't have it properly configured. Since it's super easy to enable, I think we should have it in!

I updated TW to the latest version since it wasn't working with the current one:

image

To test, you can just copy paste this piece into the homepage (page.tsx). Note the dark:bg-red-500

<code className="italic bg-base-300 dark:bg-red-500 text-base font-bold max-w-full break-words break-all inline-block">
  packages/nextjs/app/page.tsx
</code>

image
image


I had to restart the nextjs server (yarn start) to make it work after (yarn install)

@carletex carletex requested a review from technophile-04 April 12, 2024 15:23
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !! I think lot of people who don't use daisyUI and only use tailwind has this habit of using dark:

Makes a lot of sense to have it default in SE-2 too !

Tested it nicely and works great https://tw-dark-test.vercel.app/ ! Thanke Carlos 🙌

@technophile-04 technophile-04 merged commit 5d4f1c4 into main Apr 12, 2024
1 check passed
@technophile-04 technophile-04 deleted the tw-dark branch April 12, 2024 15:44
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants