Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly CLI backmerge #815

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Weekly CLI backmerge #815

merged 8 commits into from
Apr 16, 2024

Conversation

technophile-04
Copy link
Collaborator

Description

@technophile-04
Copy link
Collaborator Author

technophile-04 commented Apr 16, 2024

It was easy to backmerge then I thought

Tested and it works nicely both with foundry and hardhat and also vercel deployment and everything works great 🙌

foundry =>https://test-foundry-wagmiv2.vercel.app/
hardhat => https://test-hardhat-wagmiv2.vercel.app/

.gitignore Show resolved Hide resolved
Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few scenarios and everything seems to be working!! Thanks Shiv <3

Left a couple of comments.

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's looking good on Windows! 🙌

TYSM @technophile-04

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@technophile-04
Copy link
Collaborator Author

Tysm all for testing !! Merging this 🙌

@technophile-04 technophile-04 merged commit 7675de4 into cli Apr 16, 2024
@technophile-04 technophile-04 deleted the backmerge-wagmiv2 branch April 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants