-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly CLI backmerge #815
Weekly CLI backmerge #815
Conversation
It was easy to backmerge then I thought Tested and it works nicely both with foundry and hardhat and also vercel deployment and everything works great 🙌 foundry =>https://test-foundry-wagmiv2.vercel.app/ |
templates/base/packages/nextjs/hooks/scaffold-eth/useScaffoldContractRead.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a few scenarios and everything seems to be working!! Thanks Shiv <3
Left a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it's looking good on Windows! 🙌
TYSM @technophile-04 ♥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Tysm all for testing !! Merging this 🙌 |
Description