Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preferences for first parameter and arguments showing up on newlines #205

Merged
merged 2 commits into from
Jun 25, 2016

Conversation

jkinkead
Copy link
Collaborator

@jkinkead jkinkead commented Mar 1, 2016

Fixes #202 .

Sorry - this is a big, messy one. The underlying alignment code is complicated.

This doesn't change default behavior; that can come in a future PR.

@ghprb-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.scala-ide.org:8496/jenkins//job/ghprb-scalariform/29/
Test PASSed.

@jkinkead
Copy link
Collaborator Author

jkinkead commented Mar 7, 2016

This also fixes #158 .

@joan38
Copy link

joan38 commented Jun 17, 2016

Is this PR going to be merged? What is the road map for the 1.0?

@jkinkead
Copy link
Collaborator Author

Not being on the scala-ide team, I'm holding off on merging this until:

  1. Jenkins configuration is fixed or confirmed ignorable for PR Fix broken unit test. #225
  2. PR Fix broken unit test. #225 is merged
  3. I resolve the merge conflicts here & fix any updated tests

After that, it's mostly getting an integration test running to validate bugs #142 and #153 . I have that partially working, but have been lazy getting it fully-working (and these PRs were blocking that as well).

After that, I'll need to figure out the scala-ide release process. :P

@joan38
Copy link

joan38 commented Jun 18, 2016

Thanks for the update @jkinkead
Just for information this basically THE bug/missing feature that Intellij Idea is managing well, as well as being a Standard Scala Style, and I guess many people would like to see in.
Do people agree with this?

@jkinkead
Copy link
Collaborator Author

Yes. This 100% will be in the final release. :)

…ession

Fix unit tests broken by new defaults.
@ghprb-bot
Copy link

Test PASSed.

@jkinkead jkinkead merged commit 29f304b into scala-ide:master Jun 25, 2016
@jkinkead jkinkead deleted the align_params_regression branch June 25, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants