WIP Add line number to the ScalaParserException. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2020
mwz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at fixing #104, which has an impact on Scalastyle (#319) and I'd appreciate some early feedback on the approach I've taken. This is my first time looking at this codebase, so what I'm doing here might not be a good way of solving this. Any comments would be much appreciated.
So I essentially modified scala parsers to keep track of the current line based on the count of newline characters in the current token's text from
associatedWhitespaceAndCommentswhen thenextTokenfunction gets called. I wasn't sure if there was any better way of doing this.This is a WIP as I want to validate whether this approach is correct before writing more tests etc.