Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title for linting report of type text is not definable #1768

Closed
bekoenig opened this issue Nov 27, 2024 · 7 comments
Closed

Title for linting report of type text is not definable #1768

bekoenig opened this issue Nov 27, 2024 · 7 comments
Assignees

Comments

@bekoenig
Copy link

Description

Title of text report for lints is static (see here) and can't be defined by LintReportBuilder.

How to Reproduce

No response

Relevant log output

No response

SchemaCrawler Version

16.23.2

Java Version

21

Operating System and Version

Win 10

Relational Database System and Version

DB2LUW

JDBC Driver and Version

current

@sualeh
Copy link
Collaborator

sualeh commented Nov 27, 2024

@bekoenig This is true for all the types of SchemaCrawler reports - it is not customizable. What did you want to customize it to? The position that SchemaCrawler takes is that if you want a custom report, you can use any templating language to create a report to your liking.

@bekoenig
Copy link
Author

bekoenig commented Dec 2, 2024

It's not a problem for me, but it was confusing when I set this field and nothing happened.

@sualeh
Copy link
Collaborator

sualeh commented Dec 4, 2024

Thanks for reporting this, @bekoenig I think it is a larger issue with a number of reports. I will fix it.

@sualeh
Copy link
Collaborator

sualeh commented Dec 5, 2024

@bekoenig Sorry I have gone back and forth on what LintReport should be. Since with my changes for this issue the title and crawl information now come from standard sources like other SchemaCrawler reports, LintReport has been renamed Lints. It only contains lints, is immutable, and has useful lookup and streaming methods.

schemacrawler added a commit that referenced this issue Dec 7, 2024
Fix issue #1768 by standardizing how all reports are generated
@sualeh
Copy link
Collaborator

sualeh commented Dec 7, 2024

@bekoenig This issue is fixed. I will release it with the next SchemaCrawler release.

@sualeh sualeh closed this as completed Dec 7, 2024
@sualeh
Copy link
Collaborator

sualeh commented Dec 17, 2024

@bekoenig Please use the latest version of SchemaCrawler for more consistent reports.

@bekoenig
Copy link
Author

Thanks, works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants