-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aria selected and row attributes #491
Conversation
Aria selected and row attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wcjordan , should we also have rowAttributesGetter
work for the headers (including group header) ? If so, how should it work? Maybe it can specify the first argument with -1
and -2
for the header and group header respectively. Or maybe something like "header", "group-header".
And how should it work with multi level column headers (which will come in v2) ?
I'm not too sure. For now I recommend we leave it off, and wait to see if someone requests it down the road. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looking good from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @pradeepnschrodinger I think we can go ahead and merge unless there's something you'd like us to look further at.
@pradeepnschrodinger this hasn't gotten any attention in a little while. Is everything good to merge? |
Sorry for the delays :( Released with v1.0.1 |
Added further capabilities for rendering aria attributes
Description
Added a prop onto the Table for if it is multi-selectable. Additionally, added a callback function for adding DOM element attributes to the row div.
Motivation and Context
Creates more support for screenreaders and user customization.
Fixes #490
How Has This Been Tested?
Given that there aren't any existing tests on DOM attributes rendered, or an installed library that would do so, I did not test these changes.
Types of changes
Checklist: