Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for rowAttributesGetter #580

Merged
merged 2 commits into from
May 7, 2021

Conversation

pradeepnschrodinger
Copy link
Collaborator

Description

Added the prop type definition for rowAttributesGetter in the table component so that it appears in the generated docs.

Motivation and Context

The prop rowAttributesGetter was added along with gridAttributesGetter through #491, but only the latter prop was documented.
Partially fixes #514.

How Has This Been Tested?

Verified that The prop rowAttributesGetter was added along with gridAttributesGetter through #491, but only the latter prop was documented.
Partially fixes #514

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

ran `yarn upgrade --pattern @babel`
Adding the prop type definition makes it appear in the docs
Copy link
Member

@wcjordan wcjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pradeepnschrodinger pradeepnschrodinger changed the base branch from update-dependencies-babel-minor to v1.1.x May 7, 2021 04:45
@pradeepnschrodinger pradeepnschrodinger merged commit 78f4952 into v1.1.x May 7, 2021
@pradeepnschrodinger pradeepnschrodinger deleted the docs-rowAttributesGetter branch May 7, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants