Update issue template #565
Conversation
| @@ -0,0 +1,37 @@ | |||
| --- | |||
| name: Issue Template | |||
There was a problem hiding this comment.
We could rename this to Bug Reports, if it's clearer to the user. eg:
There was a problem hiding this comment.
Updating to Bug Reports sounds good to me
| --- | ||
| name: Issue Template | ||
| about: Template for issues | ||
| title: '' |
There was a problem hiding this comment.
Not sure if we wanna specify title here. Maybe something like "[BUG]" ? I'm inclined towards leaving this blank though.
|
|
||
| ## Steps to Reproduce (for bugs) | ||
| <!--- Provide a link to a live example, or - --> | ||
| <!--- Fork the CodePen to reproduce https://codesandbox.io/s/fixed-data-table-example-3gd9x -> |
There was a problem hiding this comment.
Updated code sandbox link. As noted in the sandbox description, this was forked from https://codesandbox.io/s/react-playground-y6zof.
The sandbox shows usage of FDT's native row expansion feature.
Right now it contains various helper cells, uses fake data store, has minimal styling done through aphrodite, and uses react state and handlers for row expansion.
Tbh, I feel this might be more complicated than what a regular user might expect when creating a new issue. If so, we could probably change the example to show a minimalistic example using fake data store; or even keep 2 links, one for basic, and one for advanced?
There was a problem hiding this comment.
I don't have a problem with making that change. Maybe we could have both a simple and an advanced sandbox example?
pradeepnschrodinger
requested review from
deshpsuy,
miskreant,
somavara,
wcjordan and
mycrobe
|
|
||
| ## Steps to Reproduce (for bugs) | ||
| <!--- Provide a link to a live example, or - --> | ||
| <!--- Fork the CodePen to reproduce https://codesandbox.io/s/fixed-data-table-example-3gd9x -> |
There was a problem hiding this comment.
nit: change CodePen to CodeSandBox
| <!--- * Basic template: https://codesandbox.io/s/fixed-data-table-basic-example-cwds0 -> | ||
| <!--- * Advanced template: https://codesandbox.io/s/fixed-data-table-advanced-example-3gd9x -> |
Let's update the issue template as per #489.
Note that this repo has had a single issue template, which'll be used whenever user tries to open up a new issue.
This is the legacy workflow, and it's defined in .github/ISSUE_TEMPLATE.md
The newer workflow, however, is to specify multiple templates and let the user choose whatever seems best.
eg (seen in react-virtualized):
For that, instead of modifying the existing
ISSUE_TEMPLATE.mdfile, we create a.mdfile for each of the templates. This PR will be for having something like the "Bug Reports" template.The only change within the contents are the codesandbox link. I specified a slightly modified version from the one mentioned in #489.
Ofc, we don't have to do all these right away. The main goal from #489 was to just update the codesandbox link. But since we're already touching the issue template, it might be best to discuss these now.