Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue template #565

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Update issue template #565

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03f3770
Update issue templates
pradeepnschrodinger Nov 16, 2020
870f29a
rename bug report, and add feature request
pradeepnschrodinger Nov 23, 2020
f7043a6
remove feature request
pradeepnschrodinger Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/ISSUE_TEMPLATE/issue-template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
---
name: Issue Template
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could rename this to Bug Reports, if it's clearer to the user. eg:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to Bug Reports sounds good to me

about: Template for issues
title: ''
Copy link
Collaborator Author

@pradeepnschrodinger pradeepnschrodinger Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we wanna specify title here. Maybe something like "[BUG]" ? I'm inclined towards leaving this blank though.

labels: ''
assignees: ''

---

<!--- Provide a general summary of the issue in the Title above -->

## Expected Behavior
<!--- If you're describing a bug, tell us what should happen -->
<!--- If you're suggesting a change/improvement, tell us how it should work -->

## Current Behavior
<!--- If describing a bug, tell us what happens instead of the expected behavior -->
<!--- If suggesting a change/improvement, explain the difference from current behavior -->

## Possible Solution
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
<!--- or ideas how to implement the addition or change -->

## Steps to Reproduce (for bugs)
<!--- Provide a link to a live example, or - -->
<!--- Fork the CodePen to reproduce https://codesandbox.io/s/fixed-data-table-example-3gd9x ->
Copy link
Collaborator Author

@pradeepnschrodinger pradeepnschrodinger Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code sandbox link. As noted in the sandbox description, this was forked from https://codesandbox.io/s/react-playground-y6zof.

The sandbox shows usage of FDT's native row expansion feature.
Right now it contains various helper cells, uses fake data store, has minimal styling done through aphrodite, and uses react state and handlers for row expansion.

Tbh, I feel this might be more complicated than what a regular user might expect when creating a new issue. If so, we could probably change the example to show a minimalistic example using fake data store; or even keep 2 links, one for basic, and one for advanced?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a problem with making that change. Maybe we could have both a simple and an advanced sandbox example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change CodePen to CodeSandBox


## Context
<!--- How has this issue affected you? What are you trying to accomplish? -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->

## Your Environment
<!--- Include as many relevant details about the environment you experienced the bug in -->
* Version used:
* Browser Name and version:
* Operating System and version (desktop or mobile):
* Link to your project: