Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice boxes' CIRCLED INFORMATION SOURCE character may appear as tofu #256

Closed
alphapapa opened this issue Aug 24, 2023 · 1 comment · Fixed by #268
Closed

Notice boxes' CIRCLED INFORMATION SOURCE character may appear as tofu #256

alphapapa opened this issue Aug 24, 2023 · 1 comment · Fixed by #268
Assignees
@alphapapa
Labels
type: Bug fix Something isn't working

Comments

@alphapapa
Copy link
Contributor

@jarrodmillman showed me these screenshots of how the notice boxes on the https://scientific-python.org/about/ page look on his Fedora system:

tofu1
tofu2

We may be able to improve this by ensuring that we select a fallback font that includes this character.
@alphapapa alphapapa added the type: Bug fix Something isn't working label Aug 24, 2023
@alphapapa alphapapa self-assigned this Aug 24, 2023
@stefanv
Copy link
Member

stefanv commented Aug 24, 2023

It renders correctly on my Fedora system, so I suppose it's a font issue indeed. Perhaps we should set more stringent font requirements and fallbacks specifically on the class attached to the icon, instead of to the whole website (I'm not sure those fallback routes will make sense to have the same, but could be).

alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue Sep 27, 2023
@alphapapa
Add: Fallback font for symbols
8b076c2 
See <scientific-python#256>.
@alphapapa alphapapa mentioned this issue Sep 27, 2023
Merged
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue Sep 27, 2023
@alphapapa
Add: Fallback font for symbols
035f7c0 
Fixes scientific-python#256.
@alphapapa alphapapa linked a pull request Sep 27, 2023 that will close this issue
Add: Fallback font for symbols #268
Merged
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue Sep 27, 2023
@alphapapa
Add: Fallback font for symbols
fb8e26b 
Fixes scientific-python#256.
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this issue Sep 27, 2023
@alphapapa
Add: Fallback font for symbols
1861df4 
Fixes scientific-python#256.
stefanv pushed a commit that referenced this issue Sep 27, 2023
@alphapapa
Add: Fallback font for symbols (#268)
a95cc57 
* Add: Fallback font for symbols

Fixes #256.

* Change: Make fallback font static

See <#268 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
type: Bug fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add: Fallback font for symbols alphapapa/scientific-python-hugo-theme
2 participants
@stefanv @alphapapa