Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Fallback font for symbols #268

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

alphapapa
Copy link
Contributor

See #256.

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df7ceaf
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65146ac5b5f806000856566b
😎 Deploy Preview https://deploy-preview-268--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95
Accessibility: 100
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alphapapa
Copy link
Contributor Author

@jarrodmillman This fallback font, Noto Sans Symbols 2, includes the 🛈 character, so this should fix rendering on your system and any other that doesn't have a system font which includes the character. Please let me know if this deploy preview renders it correctly on your system: https://deploy-preview-268--scientific-python-hugo-theme.netlify.app/shortcodes/

@alphapapa alphapapa self-assigned this Sep 27, 2023
@alphapapa alphapapa added the type: Bug fix Something isn't working label Sep 27, 2023
@alphapapa alphapapa linked an issue Sep 27, 2023 that may be closed by this pull request
Copy link
Member

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this pull request Sep 27, 2023
alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this pull request Sep 27, 2023
@jarrodmillman
Copy link
Member

hmm. It worked for me before, but I am now getting
2023-09-27T10:43:12,405714269-07:00

@stefanv
Copy link
Member

stefanv commented Sep 27, 2023

That header has font weight 700, I think, so we'd need that weight included. Perhaps 400, 700 to have bold and non-bold.

@jarrodmillman
Copy link
Member

2023-09-27T10:59:37,939673052-07:00

@alphapapa
Copy link
Contributor Author

That header has font weight 700, I think, so we'd need that weight included. Perhaps 400, 700 to have bold and non-bold.

Unfortunately, the Noto Sans Symbols 2 font only offers one weight, 400: https://fonts.google.com/noto/specimen/Noto+Sans+Symbols+2 If you'd like, I could try to dig up another fallback font that includes that symbol, but I'm not sure if there's much alternative.

This latest screenshot from Jarrod shows how it looks on his system now. What do you think?

@stefanv
Copy link
Member

stefanv commented Sep 27, 2023

That looks great!

@stefanv stefanv merged commit a95cc57 into scientific-python:main Sep 27, 2023
4 of 5 checks passed
@alphapapa alphapapa deleted the wip/256 branch September 28, 2023 03:22
@jarrodmillman jarrodmillman modified the milestone: 0.1 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice boxes' CIRCLED INFORMATION SOURCE character may appear as tofu
3 participants