Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use std::tuple_element_t as an OptionType type alias #2977

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jan 22, 2024

std::tuple_element_t was missing on some of the CI nodes. Check if this has changed. Plus, this PR should trigger all cpp tests to be run.

`std::tuple_element_t` was missing on some of the CI nodes. Check if this has changed.
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9a29ef) 81.88% compared to head (41c02a3) 81.88%.

Additional details and impacted files

Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - I think, this is ok to remove the FIXME - since we've moved to C++17 by default. I do not see any CI jobs failing, but it is possible that it is because we do not run the cpp tests on all architectures.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, std::tuple_element_t is since C++14 and we require C++17:

target_compile_features(awkward-parent INTERFACE cxx_std_17)

So please go ahead and merge this when you see fit. Thanks!

@ianna ianna merged commit 845cad7 into main Jan 24, 2024
39 checks passed
@ianna ianna deleted the ianna/use_std_for_option_type branch January 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants