-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run c++ tests in an integration build #1637
Comments
Is this still true? It's an old issue, and the testing situation may have changed. If the issue is no longer relevant, please close the issue. Thanks! |
I think, the issue is still relevant. Only 3 out of four tests are run:
I understand, that the array builder test is not a header-only test - it needs to be linked to
|
I don't think we need a C++ test for ArrayBuilder; it's tested well enough in both Python and Numba. We could just delete that one: header-only/tests/test_1542-array-builder.cpp. I just took a look at it, and it doesn't do very much, anyway. Then we're testing everything (3 out of a total of 3), right? If so, this issue could be considered resolved once test_1542-array-builder.cpp is deleted. |
Description of new feature
There are four c++ tests in
tests-cpp
that are built, but not run. They require C++17.Tasks
std::tuple_element_t
as anOptionType
type alias #2977The text was updated successfully, but these errors were encountered: