Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete header-only/tests/test_1542-array-builder.cpp #2981

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: delete header-only/tests/test_1542-array-builder.cpp #2981

merged 1 commit into from
Jan 22, 2024

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jan 22, 2024

as discussed in #1637

fixes #1637

@ianna ianna requested a review from jpivarski January 22, 2024 17:34
jpivarski
jpivarski approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Since this is not going to need any edits, I'll merge it now.

@jpivarski
Copy link
Member

That pypy segfault seems to be more frequent now...

@jpivarski jpivarski enabled auto-merge (squash) January 22, 2024 19:34
@jpivarski jpivarski merged commit 4571af9 into main Jan 22, 2024
37 of 38 checks passed
@jpivarski jpivarski deleted the ianna/delete_legacy_test branch January 22, 2024 19:36
@jpivarski jpivarski mentioned this pull request Jan 22, 2024
Closed
@ianna ianna mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: run c++ tests in an integration build
2 participants
@ianna @jpivarski