Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sort headers in GrowableBuffer.h #2976

Closed
wants to merge 1 commit into from
Closed

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Jan 22, 2024

Check if the cpp tests status, e.g. if are running in the CI.

Check if the cpp tests status, e.g. if are running in the CI.
@ianna ianna marked this pull request as draft January 22, 2024 08:53
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9a29ef) 81.88% compared to head (04363a6) 81.88%.

Additional details and impacted files

Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non kernel tests fail on Run Tests (pypy3.9, x64, ubuntu-latest, pypy)

@ianna
Copy link
Collaborator Author

ianna commented Jan 23, 2024

The issue tested in this PR is closed #1637 as completed via #2981.

@ianna ianna closed this Jan 23, 2024
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - the branch can be safely deleted.

@ianna ianna deleted the ianna/test_cpp_tests_in_ci branch February 1, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant