refactor: refactor Forth generation #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…oot5 into aryan-forth-reader-latest
for more information, see https://pre-commit.ci
jpivarski
approved these changes
Sep 20, 2022
5 tasks
|
This last pull from |
|
Yes, it was just failing due to the bug that #719 fixed. The other update is not important; go ahead and merge as-is. |
|
I had been assuming that this was merged a month ago. I'm going to see how easy it is to get in now. Doesn't #749 need to be applied on top of these changes? Are they really independent? |
jpivarski
added a commit
that referenced
this pull request
Oct 28, 2022
jpivarski
added a commit
that referenced
this pull request
Oct 28, 2022
aryan26roy
added a commit
that referenced
this pull request
Nov 6, 2022
* rename GenHelper to ForthLevelStash and add docstring with better explanation * add error handling for Python class generation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change check procedure for Forth generation * fix identation in generated Python code * add forth generation cancellation * add forth generation cancellation to streamer generated classes * Rename @aryan26roy comments to 'AwkwardForth testing'. * make forth the default * fix some tests * fix more tests * chore: remove references to Identifier (once known as Identities). * Also remove 'uproot' parameters from Forms. * Carefully merged #710 and #749. * This PR requires Awkward 2.0.0rc2. * No TVector2. * Structured the generated code in a more readable way. * change parameters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bug * fix awkward form * add streamer name * fix type * fix typo * fix awkward form * fix code generation bug * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * linting * remove ._v2 Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: jpivarski <jpivarski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.